Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: sandbox/linux/bpf_dsl/bpf_dsl.h

Issue 660153002: bpf_dsl: move more implementation details out of bpf_dsl.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: IWYU Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sandbox/linux/bpf_dsl/bpf_dsl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/linux/bpf_dsl/bpf_dsl.h
diff --git a/sandbox/linux/bpf_dsl/bpf_dsl.h b/sandbox/linux/bpf_dsl/bpf_dsl.h
index bbd92a130e8a5c75ae9c5cbc0702c5b6d496bfe8..25892b7eff51f82583c890c0bcac06970d772917 100644
--- a/sandbox/linux/bpf_dsl/bpf_dsl.h
+++ b/sandbox/linux/bpf_dsl/bpf_dsl.h
@@ -16,14 +16,6 @@
#include "sandbox/linux/bpf_dsl/trap_registry.h"
#include "sandbox/sandbox_export.h"
-namespace sandbox {
-class ErrorCode;
-class Verifier;
-namespace bpf_dsl {
-class PolicyCompiler;
-}
-}
-
// The sandbox::bpf_dsl namespace provides a domain-specific language
// to make writing BPF policies more expressive. In general, the
// object types all have value semantics (i.e., they can be copied
@@ -127,14 +119,6 @@ class SANDBOX_EXPORT SandboxBPFDSLPolicy {
static ResultExpr Trap(TrapRegistry::TrapFnc trap_func, const void* aux);
private:
- friend PolicyCompiler;
- friend Verifier;
-
- // Private methods used for compiling and verifying policies.
- ErrorCode EvaluateSyscall(PolicyCompiler* pc, int sysno) const;
- ErrorCode InvalidSyscall(PolicyCompiler* pc) const;
- bool HasUnsafeTraps() const;
-
DISALLOW_COPY_AND_ASSIGN(SandboxBPFDSLPolicy);
};
« no previous file with comments | « no previous file | sandbox/linux/bpf_dsl/bpf_dsl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698