Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 660153002: bpf_dsl: move more implementation details out of bpf_dsl.h (Closed)

Created:
6 years, 2 months ago by mdempsky
Modified:
6 years, 2 months ago
CC:
chromium-reviews, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

bpf_dsl: move more implementation details out of bpf_dsl.h BUG=414363 Committed: https://crrev.com/fe5233e8e50d6500357f01605bfd8827026604f1 Cr-Commit-Position: refs/heads/master@{#300135}

Patch Set 1 #

Patch Set 2 : Add comments #

Patch Set 3 : IWYU #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -48 lines) Patch
M sandbox/linux/bpf_dsl/bpf_dsl.h View 2 chunks +0 lines, -16 lines 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl.cc View 1 2 2 chunks +0 lines, -21 lines 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl_impl.h View 1 2 chunks +12 lines, -3 lines 0 comments Download
M sandbox/linux/bpf_dsl/policy_compiler.cc View 5 chunks +18 lines, -6 lines 0 comments Download
M sandbox/linux/seccomp-bpf/verifier.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mdempsky
jln: PTAL
6 years, 2 months ago (2014-10-17 00:27:30 UTC) #2
jln (very slow on Chromium)
lgtm
6 years, 2 months ago (2014-10-17 18:15:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660153002/30001
6 years, 2 months ago (2014-10-17 18:17:18 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:30001)
6 years, 2 months ago (2014-10-17 18:31:57 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 18:32:47 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fe5233e8e50d6500357f01605bfd8827026604f1
Cr-Commit-Position: refs/heads/master@{#300135}

Powered by Google App Engine
This is Rietveld 408576698