Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 660143002: Raise an exception when the wpr_archive_info isn't created. (Closed)

Created:
6 years, 2 months ago by ariblue
Modified:
6 years, 2 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Raise an exception when the wpr_archive_info isn't created. This is to provide a more user friendly error. This: AssertionError: Pageset archive_data_file path must be specified. instead of this: AttributeError: 'NoneType' object has no attribute 'AddNewTemporaryRecording' BUG= Committed: https://crrev.com/29846e0abbd27b05029bb3e937a6bdcbc1f31b0e Cr-Commit-Position: refs/heads/master@{#300050}

Patch Set 1 #

Patch Set 2 : perform check in record_wpr.py, not page_set.py #

Total comments: 1

Patch Set 3 : changed Exception(...) to assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/telemetry/telemetry/page/record_wpr.py View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ariblue
6 years, 2 months ago (2014-10-16 23:19:30 UTC) #2
tonyg
lgtm if you go w/ the suggestion, otherwise let's iterate https://codereview.chromium.org/660143002/diff/20001/tools/telemetry/telemetry/page/record_wpr.py File tools/telemetry/telemetry/page/record_wpr.py (right): https://codereview.chromium.org/660143002/diff/20001/tools/telemetry/telemetry/page/record_wpr.py#newcode176 ...
6 years, 2 months ago (2014-10-17 01:09:17 UTC) #3
tonyg
lgtm if you go w/ the suggestion, otherwise let's iterate
6 years, 2 months ago (2014-10-17 01:09:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660143002/40001
6 years, 2 months ago (2014-10-17 02:01:34 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-17 02:55:49 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 02:56:34 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/29846e0abbd27b05029bb3e937a6bdcbc1f31b0e
Cr-Commit-Position: refs/heads/master@{#300050}

Powered by Google App Engine
This is Rietveld 408576698