tools/telemetry/telemetry/page/record_wpr.py - Issue 660143002: Raise an exception when the wpr_archive_info isn't created.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/record_wpr.py

Issue 660143002: Raise an exception when the wpr_archive_info isn't created. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changed Exception(...) to assert Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/record_wpr.py

diff --git a/tools/telemetry/telemetry/page/record_wpr.py b/tools/telemetry/telemetry/page/record_wpr.py

index 4665371141dd9d0a7722a3527e247f218b2a27a3..97919e0157d29f9041666dd186579bbcf71fe6e4 100644

--- a/tools/telemetry/telemetry/page/record_wpr.py

+++ b/tools/telemetry/telemetry/page/record_wpr.py

@@ -172,6 +172,8 @@ class WprRecorder(object):

return ps

def Record(self, results):

+ assert self._page_set.wpr_archive_info, (

+ 'Pageset archive_data_file path must be specified.')

self._page_set.wpr_archive_info.AddNewTemporaryRecording()

self._record_page_test.CustomizeBrowserOptions(self._options)

page_runner.Run(self._record_page_test, self._page_set,

« no previous file with comments | « no previous file | no next file » | no next file with comments »