Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7495)

Unified Diff: chrome/browser/views/find_bar_host_interactive_uitest.cc

Issue 660137: Allow users to close the find session and activate the current link via ctrl-... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/find_bar_host_browsertest.cc ('k') | chrome/browser/views/find_bar_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/find_bar_host_interactive_uitest.cc
===================================================================
--- chrome/browser/views/find_bar_host_interactive_uitest.cc (revision 41087)
+++ chrome/browser/views/find_bar_host_interactive_uitest.cc (working copy)
@@ -125,7 +125,8 @@
// Ensure the creation of the find bar controller.
browser()->GetFindBarController()->Show();
EXPECT_EQ(VIEW_ID_FIND_IN_PAGE_TEXT_FIELD, GetFocusedViewID());
- browser()->GetFindBarController()->EndFindSession();
+ browser()->GetFindBarController()->EndFindSession(
+ FindBarController::kKeepSelection);
EXPECT_EQ(VIEW_ID_LOCATION_BAR, GetFocusedViewID());
// Focus the location bar, find something on the page, close the find box,
@@ -135,7 +136,8 @@
EXPECT_EQ(VIEW_ID_FIND_IN_PAGE_TEXT_FIELD, GetFocusedViewID());
ui_test_utils::FindInPage(browser()->GetSelectedTabContents(),
L"a", true, false, NULL);
- browser()->GetFindBarController()->EndFindSession();
+ browser()->GetFindBarController()->EndFindSession(
+ FindBarController::kKeepSelection);
EXPECT_EQ(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW, GetFocusedViewID());
// Focus the location bar, open and close the find box, focus should return to
@@ -145,6 +147,7 @@
EXPECT_EQ(VIEW_ID_LOCATION_BAR, GetFocusedViewID());
browser()->GetFindBarController()->Show();
EXPECT_EQ(VIEW_ID_FIND_IN_PAGE_TEXT_FIELD, GetFocusedViewID());
- browser()->GetFindBarController()->EndFindSession();
+ browser()->GetFindBarController()->EndFindSession(
+ FindBarController::kKeepSelection);
EXPECT_EQ(VIEW_ID_LOCATION_BAR, GetFocusedViewID());
}
« no previous file with comments | « chrome/browser/views/find_bar_host_browsertest.cc ('k') | chrome/browser/views/find_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698