Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chrome/browser/views/find_bar_view.cc

Issue 660137: Allow users to close the find session and activate the current link via ctrl-... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/find_bar_host_interactive_uitest.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/find_bar_view.cc
===================================================================
--- chrome/browser/views/find_bar_view.cc (revision 41087)
+++ chrome/browser/views/find_bar_view.cc (working copy)
@@ -406,7 +406,8 @@
}
break;
case CLOSE_TAG:
- find_bar_host()->GetFindBarController()->EndFindSession();
+ find_bar_host()->GetFindBarController()->EndFindSession(
+ FindBarController::kKeepSelection);
break;
default:
NOTREACHED() << L"Unknown button";
@@ -434,8 +435,7 @@
// The last two params here are forward (true) and case sensitive (false).
controller->tab_contents()->StartFinding(new_contents, true, false);
} else {
- // The textbox is empty so we reset. true = clear selection on page.
- controller->tab_contents()->StopFinding(true);
+ controller->tab_contents()->StopFinding(FindBarController::kClearSelection);
UpdateForResult(controller->tab_contents()->find_result(), string16());
}
}
« no previous file with comments | « chrome/browser/views/find_bar_host_interactive_uitest.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698