Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 66013003: Remove the word "factory" from WebSocketChannel (Closed)

Created:
7 years, 1 month ago by Adam Rice
Modified:
7 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove the word "factory" from WebSocketChannel The implementation of WebSocketChannel also contained some things calling themselves stream factories. For completeness, rename them as well. BUG=316477 TEST=net_unittests --gtest_filter=WebSocketChannel* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234827

Patch Set 1 #

Total comments: 6

Patch Set 2 : Comment fixes by tyoshino. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M net/websockets/websocket_channel.h View 1 5 chunks +8 lines, -8 lines 0 comments Download
M net/websockets/websocket_channel.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M net/websockets/websocket_channel_test.cc View 9 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Adam Rice
7 years, 1 month ago (2013-11-12 11:07:41 UTC) #1
tyoshino (SeeGerritForStatus)
lgtm https://codereview.chromium.org/66013003/diff/1/net/websockets/websocket_channel.h File net/websockets/websocket_channel.h (right): https://codereview.chromium.org/66013003/diff/1/net/websockets/websocket_channel.h#newcode91 net/websockets/websocket_channel.h:91: // Starts the connection process, using a specified ...
7 years, 1 month ago (2013-11-12 11:29:42 UTC) #2
Adam Rice
https://codereview.chromium.org/66013003/diff/1/net/websockets/websocket_channel.h File net/websockets/websocket_channel.h (right): https://codereview.chromium.org/66013003/diff/1/net/websockets/websocket_channel.h#newcode91 net/websockets/websocket_channel.h:91: // Starts the connection process, using a specified creator ...
7 years, 1 month ago (2013-11-13 03:16:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ricea@chromium.org/66013003/80001
7 years, 1 month ago (2013-11-13 12:09:34 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-13 15:59:16 UTC) #5
Message was sent while issue was closed.
Change committed as 234827

Powered by Google App Engine
This is Rietveld 408576698