[Android] Test runner for python unit tests.

[Android] Test runner for python unit tests.

BUG=424113
Committed: https://crrev.com/256fd53752aff2c311a46e7c254b9ff037088aeb
Cr-Commit-Position: refs/heads/master@{#301025}

[jbudorick, 2014-10-16 16:38:04]

jbudorick@chromium.org changed reviewers:
+ klundberg@chromium.org, mkosiba@chromium.org, navabi@chromium.org

[jbudorick, 2014-10-16 16:38:04]

I'm not crazy about this implementation, but I'm wary about getting gyp
involved. I'm open to suggestions, though.

This kind of implementation would limit the number of recipe changes we
eventually have to make as we add python unit tests.

[klundberg, 2014-10-16 17:50:15]

https://codereview.chromium.org/660023002/diff/40001/build/android/buildbot/b...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/660023002/diff/40001/build/android/buildbot/b...
build/android/buildbot/bb_device_steps.py:545: ('python_unittests',
RunPythonUnitTests),
Seems a little weird to run all Python unit tests in a single step. It makes
sense to group some together but I think at some point it will be weird to just
have this as one step.

https://codereview.chromium.org/660023002/diff/40001/build/android/python_tes...
File build/android/python_test_runner.py (right):

https://codereview.chromium.org/660023002/diff/40001/build/android/python_tes...
build/android/python_test_runner.py:16: # TODO(mkosiba): Reenable after fixing
these.
This seems a bit weird in a new file (the "reenable" part).
Did you copy this from somewhere?
I would suggest just changing it to "Enabled..."

[jbudorick, 2014-10-16 17:55:08]

https://codereview.chromium.org/660023002/diff/40001/build/android/buildbot/b...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/660023002/diff/40001/build/android/buildbot/b...
build/android/buildbot/bb_device_steps.py:545: ('python_unittests',
RunPythonUnitTests),
On 2014/10/16 17:50:15, klundberg wrote:
> Seems a little weird to run all Python unit tests in a single step. It makes
> sense to group some together but I think at some point it will be weird to
just
> have this as one step. 

That's reasonable. How would you suggest grouping them?

This is a discussion that we may also want to have w.r.t. the java unit tests,
which are currently also set to run monolithically.

https://codereview.chromium.org/660023002/diff/40001/build/android/python_tes...
File build/android/python_test_runner.py (right):

https://codereview.chromium.org/660023002/diff/40001/build/android/python_tes...
build/android/python_test_runner.py:16: # TODO(mkosiba): Reenable after fixing
these.
On 2014/10/16 17:50:15, klundberg wrote:
> This seems a bit weird in a new file (the "reenable" part).
> Did you copy this from somewhere?
> I would suggest just changing it to "Enabled..."

Hah, no. This CL was motivated by an offline conversation between mkosiba and I
this morning regarding these tests in particular.

I have no qualms with changing it to "Enabled", though, and will do so in the
next revision.

[klundberg, 2014-10-16 18:09:19]

https://codereview.chromium.org/660023002/diff/40001/build/android/buildbot/b...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/660023002/diff/40001/build/android/buildbot/b...
build/android/buildbot/bb_device_steps.py:545: ('python_unittests',
RunPythonUnitTests),
On 2014/10/16 17:55:07, jbudorick wrote:
> On 2014/10/16 17:50:15, klundberg wrote:
> > Seems a little weird to run all Python unit tests in a single step. It makes
> > sense to group some together but I think at some point it will be weird to
> just
> > have this as one step. 
> 
> That's reasonable. How would you suggest grouping them?

Not sure exactly what tests we have but something like:
- device-related unit tests
- test runner unit tests
- ...
Or maybe have one for core pylib and others for non-pylib? Not sure what makes
sense?

> 
> This is a discussion that we may also want to have w.r.t. the java unit tests,
> which are currently also set to run monolithically.

[jbudorick, 2014-10-21 16:46:32]

I moved the test running logic into test_runner.py. Python unit tests are now
run via:

  ./build/android/test_runner.py python -s <suite_name>

and I moved the suite definitions into b/a/pylib/constants.py

ptal

[klundberg, 2014-10-21 19:05:41]

lgtm

Thanks, John!

I like this approach much better.

[jbudorick, 2014-10-21 19:08:09]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-10-21 19:08:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/660023002/60001

[commit-bot: I haz the power, 2014-10-21 19:18:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-21 19:18:37]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jbudorick, 2014-10-21 19:19:51]

On 2014/10/21 19:18:37, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

thwarted by buildbot OWNERS again...

[jbudorick, 2014-10-24 00:51:55]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-10-24 00:54:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/660023002/80001

[commit-bot: I haz the power, 2014-10-24 01:50:26]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-10-24 01:51:12]

Patchset 5 (id:??) landed as
https://crrev.com/256fd53752aff2c311a46e7c254b9ff037088aeb
Cr-Commit-Position: refs/heads/master@{#301025}