Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 659923003: Revert of [Telemetry] Always use ephemeral port chosen by Chrome. (Closed)

Created:
6 years, 2 months ago by tonyg
Modified:
6 years, 2 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Telemetry] Always use ephemeral port chosen by Chrome. (patchset #1 id:1 of https://codereview.chromium.org/650963003/) Reason for revert: Possibly caused flake. Will reland if mistaken. BUG=424245 Original issue's description: > [Telemetry] Always use ephemeral port chosen by Chrome. > > This reduces a potential source of flake for desktop Chrome. The > reference builds are now M37 (and I've verified they behave properly) > and stable is now M38. > > BUG=379980 > > Committed: https://crrev.com/f71a95de8adcd6cab36f87d669feda3fb1984896 > Cr-Commit-Position: refs/heads/master@{#299621} TBR=kbr@chromium.org,dtu@chromium.org NOTREECHECKS=true NOTRY=true BUG=379980 Committed: https://crrev.com/38ff80f84aece49c51a23dcc56ae36d6666718d7 Cr-Commit-Position: refs/heads/master@{#299913}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -33 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py View 2 chunks +38 lines, -33 lines 0 comments Download
M tools/telemetry/telemetry/core/browser_options.py View 2 chunks +6 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/browser_options_unittest.py View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tonyg
Created Revert of [Telemetry] Always use ephemeral port chosen by Chrome.
6 years, 2 months ago (2014-10-16 17:26:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659923003/1
6 years, 2 months ago (2014-10-16 17:28:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 17:30:20 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 17:31:14 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38ff80f84aece49c51a23dcc56ae36d6666718d7
Cr-Commit-Position: refs/heads/master@{#299913}

Powered by Google App Engine
This is Rietveld 408576698