tools/telemetry/telemetry/core/browser_options.py - Issue 659923003: Revert of [Telemetry] Always use ephemeral port chosen by Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/browser_options.py

Issue 659923003: Revert of [Telemetry] Always use ephemeral port chosen by Chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py ('k') | tools/telemetry/telemetry/core/browser_options_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/browser_options.py

diff --git a/tools/telemetry/telemetry/core/browser_options.py b/tools/telemetry/telemetry/core/browser_options.py

index fb7efa7fbf6cc354c3f97370fadf80f47d90d6c1..c097ea7b78a6f84411c5259dcdb9226d0c5bb37b 100644

--- a/tools/telemetry/telemetry/core/browser_options.py

+++ b/tools/telemetry/telemetry/core/browser_options.py

@@ -203,6 +203,11 @@

# performance measurements.

self.disable_component_extensions_with_background_pages = True

+ # Whether to use the new code path for choosing an ephemeral port for

+ # DevTools. The bots set this to true. When Chrome 37 reaches stable,

+ # remove this setting and the old code path. http://crbug.com/379980

+ self.use_devtools_active_port = False

def __repr__(self):

return str(sorted(self.__dict__.items()))

@@ -278,6 +283,7 @@

'profile_type',

'show_stdout',

'synthetic_gesture_source_type',

+ 'use_devtools_active_port',

]

for o in browser_options_list:

a = getattr(finder_options, o, None)