Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 659883003: gpu: Move image creation part of GpuMemoryBufferFactory interface to gpu namespace. (Closed)

Created:
6 years, 2 months ago by reveman
Modified:
6 years, 1 month ago
Reviewers:
no sievers
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move-gpu-memory-buffer-manager-to-gpu
Project:
chromium
Visibility:
Public.

Description

gpu: Move image creation part of GpuMemoryBufferFactory interface to gpu namespace. This moves the image creation part of the GpuMemoryBufferFactory interface to a new ImageFactory interface in the gpu namespace. This is necessary for in-process command buffer to be able to create images. This also moves some utility functions from CommandBufferProxy to this new ImageFactory interface so they can be reused by the in-process command buffer code. BUG=423533 Committed: https://crrev.com/eeba91b525f74890247a93fe022054f12aee18cc Cr-Commit-Position: refs/heads/master@{#301732}

Patch Set 1 #

Patch Set 2 : add missing file #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -78 lines) Patch
M content/common/gpu/client/command_buffer_proxy_impl.cc View 3 chunks +5 lines, -62 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory.h View 2 chunks +6 lines, -9 lines 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_android.cc View 2 chunks +6 lines, -1 line 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_mac.cc View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_ozone.cc View 1 2 3 chunks +6 lines, -1 line 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_win.cc View 2 chunks +6 lines, -1 line 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_x11.cc View 2 chunks +6 lines, -1 line 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A gpu/command_buffer/service/image_factory.h View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
A gpu/command_buffer/service/image_factory.cc View 1 2 1 chunk +76 lines, -0 lines 0 comments Download
M gpu/command_buffer_service.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
reveman
6 years, 2 months ago (2014-10-17 19:52:02 UTC) #2
no sievers
lgtm
6 years, 2 months ago (2014-10-17 20:20:10 UTC) #3
no sievers
Did you forget to add image_factory.cc from https://codereview.chromium.org/665463003 into this patchset?
6 years, 2 months ago (2014-10-17 20:40:37 UTC) #4
reveman
On 2014/10/17 20:40:37, sievers wrote: > Did you forget to add image_factory.cc from > https://codereview.chromium.org/665463003 ...
6 years, 2 months ago (2014-10-17 21:45:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659883003/40001
6 years, 1 month ago (2014-10-28 22:04:32 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-28 22:49:35 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 22:50:14 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/eeba91b525f74890247a93fe022054f12aee18cc
Cr-Commit-Position: refs/heads/master@{#301732}

Powered by Google App Engine
This is Rietveld 408576698