Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2518)

Unified Diff: content/common/gpu/gpu_memory_buffer_factory.h

Issue 659883003: gpu: Move image creation part of GpuMemoryBufferFactory interface to gpu namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-gpu-memory-buffer-manager-to-gpu
Patch Set: rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/gpu_memory_buffer_factory.h
diff --git a/content/common/gpu/gpu_memory_buffer_factory.h b/content/common/gpu/gpu_memory_buffer_factory.h
index 473f30b1d2de10db741f2e58063e486f8021504f..0c06537b3c484588eab1695d728cdd3c8d519102 100644
--- a/content/common/gpu/gpu_memory_buffer_factory.h
+++ b/content/common/gpu/gpu_memory_buffer_factory.h
@@ -14,6 +14,10 @@ namespace gfx {
class GLImage;
}
+namespace gpu {
+class ImageFactory;
+}
+
namespace content {
class GpuMemoryBufferFactory {
@@ -37,15 +41,8 @@ class GpuMemoryBufferFactory {
virtual void DestroyGpuMemoryBuffer(
const gfx::GpuMemoryBufferHandle& handle) = 0;
- // Creates a GLImage instance for GPU memory buffer identified by |handle|.
- // |client_id| should be set to the client requesting the creation of instance
- // and can be used by factory implementation to verify access rights.
- virtual scoped_refptr<gfx::GLImage> CreateImageForGpuMemoryBuffer(
- const gfx::GpuMemoryBufferHandle& handle,
- const gfx::Size& size,
- gfx::GpuMemoryBuffer::Format format,
- unsigned internalformat,
- int client_id) = 0;
+ // Type-checking downcast routine.
+ virtual gpu::ImageFactory* AsImageFactory() = 0;
private:
DISALLOW_COPY_AND_ASSIGN(GpuMemoryBufferFactory);
« no previous file with comments | « content/common/gpu/gpu_command_buffer_stub.cc ('k') | content/common/gpu/gpu_memory_buffer_factory_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698