Always run tests that do not require targets to compile,

Always run tests that do not require targets to compile,

even if the patch doesn't require compile.

BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292542

[Paweł Hajdan Jr., 2014-10-16 15:18:29]

phajdan.jr@chromium.org changed reviewers:
+ sky@chromium.org

[Paweł Hajdan Jr., 2014-10-16 15:18:29]

For example, I'd expect
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...
to run checkdeps, but it didn't.

We'll probably also need to add src/testing/scripts to exclude list for analyze.

[sky, 2014-10-16 16:44:18]

https://codereview.chromium.org/659863004/diff/1/scripts/slave/recipes/chromi...
File scripts/slave/recipes/chromium_trybot.py (right):

https://codereview.chromium.org/659863004/diff/1/scripts/slave/recipes/chromi...
scripts/slave/recipes/chromium_trybot.py:841: if not requires_compile:
Document why we do this.

https://codereview.chromium.org/659863004/diff/1/scripts/slave/recipes/chromi...
scripts/slave/recipes/chromium_trybot.py:842: tests = [t for t in tests if not
t.compile_targets(api)]
Should an explicit function be added instead of relying on empty
compile_targets? For example, seems like with this change DynamicPerfTests would
get run, and I'm not sure it should. It also looks like ios bots always return
[].

[Paweł Hajdan Jr., 2014-10-17 10:42:11]

PTAL

https://codereview.chromium.org/659863004/diff/1/scripts/slave/recipes/chromi...
File scripts/slave/recipes/chromium_trybot.py (right):

https://codereview.chromium.org/659863004/diff/1/scripts/slave/recipes/chromi...
scripts/slave/recipes/chromium_trybot.py:841: if not requires_compile:
On 2014/10/16 16:44:18, sky wrote:
> Document why we do this.

Done.

https://codereview.chromium.org/659863004/diff/1/scripts/slave/recipes/chromi...
scripts/slave/recipes/chromium_trybot.py:842: tests = [t for t in tests if not
t.compile_targets(api)]
On 2014/10/16 16:44:18, sky wrote:
> Should an explicit function be added instead of relying on empty
> compile_targets? For example, seems like with this change DynamicPerfTests
would
> get run, and I'm not sure it should. It also looks like ios bots always return
> [].

I'd prefer to keep the interface of Test small. We're also in the process of
migrating steps.py to just use ScriptTest and move more logic src-side.

Neither DynamicPerfTests not ios tests are used by this recipe, and I'd prefer
to address them specifically when needed. If a test is relying on a compile
target, it should specify so or just not use the "analyze" step in the worst
case.

[sky, 2014-10-20 15:50:34]

LGTM

[Paweł Hajdan Jr., 2014-10-21 07:56:06]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2014-10-21 07:56:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/659863004/20001

[commit-bot: I haz the power, 2014-10-21 07:58:12]

Committed patchset #2 (id:20001) as 292542