Always run tests that do not require targets to compile,

scripts/slave/recipes/chromium_trybot.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 DEPS = [
   'bot_update',
   'chromium',
   'chromium_tests',
   'gclient',
   'isolate',
@@ skipping 782 matching lines @@
 
     # Tests that are only run if their compile_targets are going to be built.
     conditional_tests = [api.chromium.steps.NaclIntegrationTest()]
     if bot_config.get('add_telemetry_tests', True):
       conditional_tests += [api.chromium.steps.TelemetryUnitTests(),
                             api.chromium.steps.TelemetryPerfUnitTests()]
 
     # See if the patch needs to compile on the current platform.
     # Don't run analyze for other projects, such as blink, as there aren't that
     # many try jobs for them.
+    requires_compile = True
     if isinstance(test_spec, dict) and api.properties.get('root') == 'src':
       analyze_config_file = bot_config['testing'].get('analyze_config_file',
                                          'trybot_analyze_config.json')
       requires_compile, matching_exes, compile_targets = \
           api.chromium_tests.analyze(
               get_test_names(gtest_tests) +
                   all_compile_targets(api, conditional_tests),
               compile_targets,
               analyze_config_file)
 
-      if not requires_compile:
-        return [], bot_update_step
-
       gtest_tests = filter_tests(gtest_tests, matching_exes)
 
     tests = []
     # TODO(phajdan.jr): Re-enable checkdeps on Windows when it works with git.
     if not api.platform.is_win:
       tests.append(api.chromium.steps.ScriptTest('checkdeps', 'checkdeps.py'))
     if api.platform.is_linux:
       tests.extend([
           api.chromium.steps.CheckpermsTest(),
           api.chromium.steps.ChecklicensesTest(),
       ])
 
     conditional_tests = tests_in_compile_targets(
         api, compile_targets, conditional_tests)
     tests.extend(find_test_named(api.chromium.steps.TelemetryUnitTests.name,
                                  conditional_tests))
     tests.extend(find_test_named(api.chromium.steps.TelemetryPerfUnitTests.name,
                                  conditional_tests))
     tests.extend(gtest_tests)
     tests.extend(find_test_named(api.chromium.steps.NaclIntegrationTest.name,
                                  conditional_tests))
     # MojoPythonTests don't require anything to be compiled.
     tests.append(api.chromium.steps.MojoPythonTests())
 
     if api.platform.is_win:
       tests.append(api.chromium.steps.MiniInstallerTest())
 
+    if not requires_compile:

[sky, 2014/10/16 16:44:18]

Document why we do this.

[Paweł Hajdan Jr., 2014/10/17 10:42:11]

Done.

+      tests = [t for t in tests if not t.compile_targets(api)]

[sky, 2014/10/16 16:44:18]

Should an explicit function be added instead of relying on empty
compile_targets? For example, seems like with this change DynamicPerfTests would
get run, and I'm not sure it should. It also looks like ios bots always return
[].

[Paweł Hajdan Jr., 2014/10/17 10:42:11]

I'd prefer to keep the interface of Test small. We're also in the process of
migrating steps.py to just use ScriptTest and move more logic src-side.

Neither DynamicPerfTests not ios tests are used by this recipe, and I'd prefer
to address them specifically when needed. If a test is relying on a compile
target, it should specify so or just not use the "analyze" step in the worst
case.

+      return tests, bot_update_step
+
     has_swarming_tests = any(t.uses_swarming for t in tests)
 
     # Swarming uses Isolate to transfer files to swarming bots.
     # set_isolate_environment modifies GYP_DEFINES to enable test isolation.
     if bot_config.get('use_isolate') or has_swarming_tests:
       api.isolate.set_isolate_environment(api.chromium.c)
 
     # If going to use swarming_client (pinned in src/DEPS), ensure it is
     # compatible with what recipes expect.
     if has_swarming_tests:
@@ skipping 99 matching lines @@
             master_dict,
             override_bot_type='builder_tester',
             override_tests=tests)
 
     requires_compile, matching_exes, compile_targets = \
         api.chromium_tests.analyze(
             all_compile_targets(api, tests + tests_including_triggered),
             compile_targets,
             'trybot_analyze_config.json')
 
-    if not requires_compile:
-      return
+    if requires_compile:
+      tests = filter_tests(tests, matching_exes)
+      tests_including_triggered = filter_tests(
+          tests_including_triggered, matching_exes)
 
-    tests = filter_tests(tests, matching_exes)
-    tests_including_triggered = filter_tests(
-        tests_including_triggered, matching_exes)
+      api.chromium_tests.compile_specific_targets(
+          main_waterfall_config['mastername'],
+          main_waterfall_config['buildername'],
+          bot_update_step,
+          master_dict,
+          test_spec,
+          compile_targets,
+          tests_including_triggered,
+          override_bot_type='builder_tester')
+    else:
+      tests = [t for t in tests if not t.compile_targets(api)]
 
-    api.chromium_tests.compile_specific_targets(
-        main_waterfall_config['mastername'],
-        main_waterfall_config['buildername'],
-        bot_update_step,
-        master_dict,
-        test_spec,
-        compile_targets,
-        tests_including_triggered,
-        override_bot_type='builder_tester')
   else:
     # TODO(phajdan.jr): Remove the legacy trybot-specific codepath.
     tests, bot_update_step = compile_and_return_tests(
         mastername, buildername)
 
   def deapply_patch_fn(failing_tests):
     api.chromium_tests.deapply_patch(bot_update_step)
     compile_targets = list(api.itertools.chain(
         *[t.compile_targets(api) for t in failing_tests]))
     if compile_targets:
@@ skipping 550 matching lines @@
           },
         ],
       })
     ) +
     api.override_step_data(
       'analyze',
       api.json.output({'status': 'Found dependency',
                        'targets': ['browser_tests', 'base_unittests'],
                        'build_targets': ['base_unittests']}))
   )