Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 65983002: Revert 231221 - "Remove enabled/disabled state from extension and app sync." (Closed)

Created:
7 years, 1 month ago by Yoyo Zhou
Modified:
7 years, 1 month ago
Reviewers:
Nicolas Zea, Matt Perry
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, haitaol+watch_chromium.org, albertb+watch_chromium.org, chromium-apps-reviews_chromium.org, rsimha+watch_chromium.org
Visibility:
Public.

Description

Revert 231221 - "Remove enabled/disabled state from extension and app sync." Some differences to account for ExtensionService's sync handling moving to ExtensionSyncService. BUG=303311, 316368 TBR=zea@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233885

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -9 lines) Patch
M chrome/browser/extensions/extension_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 16 chunks +135 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_sync_service.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/apps_helper.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/apps_helper.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/extensions_helper.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/extensions_helper.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/performance/extensions_sync_perf_test.cc View 4 chunks +23 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_extension_helper.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_extension_helper.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_apps_sync_test.cc View 2 chunks +30 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_extensions_sync_test.cc View 2 chunks +31 lines, -0 lines 0 comments Download
M sync/protocol/extension_specifics.proto View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yoyo Zhou
mpcomplete: this is basically a revert accounting for the underlying code having moved around slightly. ...
7 years, 1 month ago (2013-11-08 00:24:37 UTC) #1
Matt Perry
lgtm
7 years, 1 month ago (2013-11-08 00:35:32 UTC) #2
Yoyo Zhou
zea, TBR
7 years, 1 month ago (2013-11-08 00:58:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/65983002/1
7 years, 1 month ago (2013-11-08 01:08:38 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-08 12:26:48 UTC) #5
Message was sent while issue was closed.
Change committed as 233885

Powered by Google App Engine
This is Rietveld 408576698