Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1314)

Unified Diff: sync/protocol/extension_specifics.proto

Issue 65983002: Revert 231221 - "Remove enabled/disabled state from extension and app sync." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/test/integration/two_client_extensions_sync_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/protocol/extension_specifics.proto
diff --git a/sync/protocol/extension_specifics.proto b/sync/protocol/extension_specifics.proto
index 4c8364ad2a40427ad62611cb9b9a8f3c158bfbcb..e3e1dfbfa8ddc8a48d47af72812a1d10a868c149 100644
--- a/sync/protocol/extension_specifics.proto
+++ b/sync/protocol/extension_specifics.proto
@@ -29,11 +29,6 @@ message ExtensionSpecifics {
// Extensions Gallery) is used.
optional string update_url = 3;
// Whether or not this extension is enabled.
- // TODO(yoz): New sync clients will ignore this state, but we must
- // keep populating it because old clients behave incorrectly if it's
- // not present. Temporarily, enabled changes will propagate from new
- // clients to old, but not vice versa. Once all clients are updated to
- // ignore this field, we can remove it. See crbug.com/303311.
optional bool enabled = 4;
// Whether or not this extension is enabled in incognito mode.
optional bool incognito_enabled = 5;
« no previous file with comments | « chrome/browser/sync/test/integration/two_client_extensions_sync_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698