[Password Generation] Always query password forms via Autofill

chrome/browser/autofill/autofill_server_browsertest.cc

Index: chrome/browser/autofill/autofill_server_browsertest.cc
diff --git a/chrome/browser/autofill/autofill_server_browsertest.cc b/chrome/browser/autofill/autofill_server_browsertest.cc
index 49c8bc973b59816c6c33875bc4e6e92bf9408b81..5e72afef8650dbbf80719de948e676a61a7c4966 100644
--- a/chrome/browser/autofill/autofill_server_browsertest.cc
+++ b/chrome/browser/autofill/autofill_server_browsertest.cc
@@ -70,6 +70,7 @@ class WindowedNetworkObserver : public net::TestURLFetcher::DelegateForTests {
   // net::TestURLFetcher::DelegateForTests:
   void OnRequestStart(int fetcher_id) override {
     net::TestURLFetcher* fetcher = factory_->GetFetcherByID(fetcher_id);
+    LOG(INFO) << fetcher->upload_data();

[Ilya Sherman, 2014/10/24 01:24:45]

nit: Please revert.

[Garrett Casto, 2014/10/24 21:13:09]

Done.

     if (fetcher->upload_data() == expected_upload_data_)
       message_loop_runner_->Quit();
 
@@ -169,4 +170,32 @@ IN_PROC_BROWSER_TEST_F(AutofillServerTest,
   upload_network_observer.Wait();
 }
 
+// Verify that a site with password fields will query even in the presence
+// of user defined autocomplete types.
+IN_PROC_BROWSER_TEST_F(AutofillServerTest,
+                       AlwaysQueryForPasswordFields) {
+  // Load the test page. Expect a query request upon loading the page.
+  const char kDataURIPrefix[] = "data:text/html;charset=utf-8,";
+  const char kFormHtml[] =
+      "<form id='test_form'>"
+      "  <input type='text' id='one' autocomplete='username'>"
+      "  <input type='text' id='two' autocomplete='off'>"
+      "  <input type='password' id='three'>"
+      "  <input type='submit'>"
+      "</form>";
+  const char kQueryRequest[] =
+      "<?xml version=\"1.0\" encoding=\"UTF-8\"?>"
+      "<autofillquery clientversion=\"6.1.1715.1442/en (GGLL)\">"
+      "<form signature=\"8900697631820480876\">"
+      "<field signature=\"2594484045\"/>"
+      "<field signature=\"2750915947\"/>"
+      "<field signature=\"116843943\"/>"
+      "</form>"
+      "</autofillquery>";
+  WindowedNetworkObserver query_network_observer(kQueryRequest);
+  ui_test_utils::NavigateToURL(
+      browser(), GURL(std::string(kDataURIPrefix) + kFormHtml));
+  query_network_observer.Wait();
+}
+
 }  // namespace autofill