[Password Generation] Always query password forms via Autofill

chrome/browser/autofill/autofill_server_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/autofill/personal_data_manager_factory.h"
@@ skipping 52 matching lines @@
 
   // Waits for a network request with the |expected_upload_data_|.
   void Wait() {
     message_loop_runner_->Run();
     factory_.reset();
   }
 
   // net::TestURLFetcher::DelegateForTests:
   void OnRequestStart(int fetcher_id) override {
     net::TestURLFetcher* fetcher = factory_->GetFetcherByID(fetcher_id);
+    LOG(INFO) << fetcher->upload_data();

[Ilya Sherman, 2014/10/24 01:24:45]

nit: Please revert.

[Garrett Casto, 2014/10/24 21:13:09]

Done.

     if (fetcher->upload_data() == expected_upload_data_)
       message_loop_runner_->Quit();
 
     // Not interested in any further status updates from this fetcher.
     fetcher->SetDelegateForTests(NULL);
   }
   void OnChunkUpload(int fetcher_id) override {}
   void OnRequestEnd(int fetcher_id) override {}
 
  private:
@@ skipping 79 matching lines @@
       "<field signature=\"1236501728\" autofilltype=\"2\"/>"
       "</autofillupload>";
   WindowedNetworkObserver upload_network_observer(kUploadRequest);
   content::WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   content::SimulateMouseClick(
       web_contents, 0, blink::WebMouseEvent::ButtonLeft);
   upload_network_observer.Wait();
 }
 
+// Verify that a site with password fields will query even in the presence
+// of user defined autocomplete types.
+IN_PROC_BROWSER_TEST_F(AutofillServerTest,
+                       AlwaysQueryForPasswordFields) {
+  // Load the test page. Expect a query request upon loading the page.
+  const char kDataURIPrefix[] = "data:text/html;charset=utf-8,";
+  const char kFormHtml[] =
+      "<form id='test_form'>"
+      "  <input type='text' id='one' autocomplete='username'>"
+      "  <input type='text' id='two' autocomplete='off'>"
+      "  <input type='password' id='three'>"
+      "  <input type='submit'>"
+      "</form>";
+  const char kQueryRequest[] =
+      "<?xml version=\"1.0\" encoding=\"UTF-8\"?>"
+      "<autofillquery clientversion=\"6.1.1715.1442/en (GGLL)\">"
+      "<form signature=\"8900697631820480876\">"
+      "<field signature=\"2594484045\"/>"
+      "<field signature=\"2750915947\"/>"
+      "<field signature=\"116843943\"/>"
+      "</form>"
+      "</autofillquery>";
+  WindowedNetworkObserver query_network_observer(kQueryRequest);
+  ui_test_utils::NavigateToURL(
+      browser(), GURL(std::string(kDataURIPrefix) + kFormHtml));
+  query_network_observer.Wait();
+}
+
 }  // namespace autofill