Fix issue 21159: prevent endless inlining of field dispatchers.

runtime/vm/flow_graph_inliner.cc

Index: runtime/vm/flow_graph_inliner.cc
===================================================================
--- runtime/vm/flow_graph_inliner.cc	(revision 41134)
+++ runtime/vm/flow_graph_inliner.cc	(working copy)
@@ -764,11 +764,12 @@
             &call_data->caller, &function, call_data->call);
         return false;
       }
-
-      if (function.IsInvokeFieldDispatcher() ||
-          function.IsNoSuchMethodDispatcher()) {
+      if ((GrowthFactor() < 10.0) &&

[Florian Schneider, 2014/10/16 10:34:33]

We need to avoid infinite recursion, but not sure if this is the best way: The
idea is to always inline those dispatchers since they are small and should not
get into the way when generating optimized code. 

+          (function.IsInvokeFieldDispatcher() ||
+          function.IsNoSuchMethodDispatcher())) {
         // Append call sites to the currently processed list so that dispatcher
         // methods get inlined regardless of the current depth.
+        // Use GrowthFactor to prevent endless recursive inlining.
         inlining_call_sites_->FindCallSites(callee_graph,
                                             0,
                                             &inlined_info_);