Fix issue 21159: prevent endless inlining of field dispatchers.

runtime/vm/flow_graph_inliner.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_inliner.h"
 
 #include "vm/block_scheduler.h"
 #include "vm/compiler.h"
 #include "vm/flags.h"
 #include "vm/flow_graph.h"
@@ skipping 746 matching lines @@
                                  "code size:  %" Pd ", "
                                  "call sites: %" Pd ", "
                                  "const args: %" Pd "\n",
                                  size,
                                  call_site_count,
                                  constants_count));
         PRINT_INLINING_TREE("Heuristic fail",
             &call_data->caller, &function, call_data->call);
         return false;
       }
-
-      if (function.IsInvokeFieldDispatcher() ||
-          function.IsNoSuchMethodDispatcher()) {
+      if ((GrowthFactor() < 10.0) &&

[Florian Schneider, 2014/10/16 10:34:33]

We need to avoid infinite recursion, but not sure if this is the best way: The
idea is to always inline those dispatchers since they are small and should not
get into the way when generating optimized code. 

+          (function.IsInvokeFieldDispatcher() ||
+          function.IsNoSuchMethodDispatcher())) {
         // Append call sites to the currently processed list so that dispatcher
         // methods get inlined regardless of the current depth.
+        // Use GrowthFactor to prevent endless recursive inlining.
         inlining_call_sites_->FindCallSites(callee_graph,
                                             0,
                                             &inlined_info_);
       } else {
         collected_call_sites_->FindCallSites(callee_graph,
                                              inlining_depth_,
                                              &inlined_info_);
       }
 
       // Add the function to the cache.
@@ skipping 921 matching lines @@
         OS::Print("After Inlining of %s\n", flow_graph_->
                   parsed_function().function().ToFullyQualifiedCString());
         FlowGraphPrinter printer(*flow_graph_);
         printer.PrintBlocks();
       }
     }
   }
 }
 
 }  // namespace dart