Issue 6597042: Fix a stack height mismatch when deoptimizing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6597042: Fix a stack height mismatch when deoptimizing. (Closed)

Created:
9 years, 9 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
fschneider, Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge/build/ia32

Visibility:
Public.

Description

Fix a stack height mismatch when deoptimizing. When deoptimizing from the key subexpression of a keyed arguments access, the unoptimized code expects to find the value of the receiver on the expression stack. The environment of the optimizing compiler did not contain this value during evaluation of the key subexpression. BUG=v8:1210

Patch Set 1 #

Patch Set 2 : Fix typo in comment in test case. #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -0 lines)			Patch
	M	src/hydrogen.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	A	test/mjsunit/regress/regress-1210.js	View	1	1 chunk	+48 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages