Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 659703002: GN: Some small changes to support chrome android internal stuff (Closed)

Created:
6 years, 2 months ago by cjhopman
Modified:
6 years, 2 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-packed
Project:
chromium
Visibility:
Public.

Description

GN: Some small changes to support chrome android internal stuff This actually hooks up (i.e. passes from invoker) several variables controlling apk creation (version name, version code, use_relocation_packer, use_chromium_linker, unzip_libraries_from_apk). Adds support for overriding some configuration in the private repo. Adds support for public_configs in grit_rule.gni. Adds some junit targets (these are built as android libraries currently instead of host libraries, but that just means we do a bit extra work that we don't really need). BUG=359249 Committed: https://crrev.com/ca675d3ec565477b2e3bae8b0709a412d029fa21 Cr-Commit-Position: refs/heads/master@{#301039}

Patch Set 1 : #

Patch Set 2 : line length #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -90 lines) Patch
M BUILD.gn View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M build/config/android/config.gni View 1 2 3 chunks +16 lines, -4 lines 0 comments Download
M build/config/android/internal_rules.gni View 2 chunks +3 lines, -3 lines 0 comments Download
M build/config/android/rules.gni View 1 2 4 chunks +19 lines, -1 line 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_android_paks.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/BUILD.gn View 3 chunks +7 lines, -2 lines 0 comments Download
A testing/android/junit/BUILD.gn View 1 chunk +27 lines, -0 lines 0 comments Download
M testing/android/junit/junit_test.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
A third_party/junit/BUILD.gn View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/junit/junit.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/libaddressinput/BUILD.gn View 1 1 chunk +91 lines, -78 lines 0 comments Download
M third_party/libaddressinput/libaddressinput.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
cjhopman
brettw/yfriedman: ptal at how internal configuration is injected in //BUILD.gn and //build/config/android/config.gni jbudorick: junit stuff ...
6 years, 2 months ago (2014-10-15 20:54:22 UTC) #4
cjhopman
6 years, 2 months ago (2014-10-15 21:04:46 UTC) #6
Evan Stade
rs lgtm for libaddressinput
6 years, 2 months ago (2014-10-15 21:43:30 UTC) #7
brettw
lgtm
6 years, 2 months ago (2014-10-15 22:33:19 UTC) #8
sky
chrome LGTM
6 years, 2 months ago (2014-10-15 23:58:01 UTC) #9
Yaron
lgtm
6 years, 2 months ago (2014-10-16 00:52:41 UTC) #10
jbudorick
junit lgtm
6 years, 2 months ago (2014-10-16 07:43:35 UTC) #11
ygorshenin1
components/ownership/ lgtm.
6 years, 2 months ago (2014-10-17 10:00:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659703002/60001
6 years, 2 months ago (2014-10-24 01:48:26 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/83295) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/72945) win_gpu ...
6 years, 2 months ago (2014-10-24 01:55:27 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659703002/80001
6 years, 2 months ago (2014-10-24 02:12:39 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:80001)
6 years, 2 months ago (2014-10-24 03:50:53 UTC) #19
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 03:51:50 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ca675d3ec565477b2e3bae8b0709a412d029fa21
Cr-Commit-Position: refs/heads/master@{#301039}

Powered by Google App Engine
This is Rietveld 408576698