Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: third_party/libaddressinput/BUILD.gn

Issue 659703002: GN: Some small changes to support chrome android internal stuff (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-packed
Patch Set: rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/junit/junit.gyp ('k') | third_party/libaddressinput/libaddressinput.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libaddressinput/BUILD.gn
diff --git a/third_party/libaddressinput/BUILD.gn b/third_party/libaddressinput/BUILD.gn
index 2f2bb03a2a6ce5cc4bb5b965b30b07afa18672be..bb32d46fd20e5ca3ff7b07390f78d305b4a195db 100644
--- a/third_party/libaddressinput/BUILD.gn
+++ b/third_party/libaddressinput/BUILD.gn
@@ -125,82 +125,95 @@ static_library("util") {
]
}
-if (!is_android) {
-
-# The list of files in libaddressinput.gypi.
-gypi_values = exec_script(
- "//build/gypi_to_gn.py",
- [ rebase_path("src/cpp/libaddressinput.gypi") ],
- "scope",
- [ "src/cpp/libaddressinput.gypi" ])
-
-
-# This target provides more complicated functionality like pinging servers
-# for validation rules.
-# GYP version: third_party/libaddressinput/libaddressinput.gyp:libaddressinput
-static_library("libaddressinput") {
- sources = rebase_path(gypi_values.libaddressinput_files, ".", "src/cpp")
- sources += [
- "chromium/chrome_address_validator.cc",
- "chromium/chrome_metadata_source.cc",
- "chromium/chrome_storage_impl.cc",
- "chromium/fallback_data_store.cc",
- "chromium/input_suggester.cc",
- "chromium/string_compare.cc",
- "chromium/trie.cc",
- ]
- sources -= libaddressinput_util_files
- sources -= [
- "src/cpp/src/util/string_compare.cc",
- ]
-
- configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [ "//build/config/compiler:no_chromium_code" ]
-
- public_configs = [ ":libaddressinput_config" ]
-
- deps = [
- ":strings",
- ":util",
- "//base",
- "//base:i18n",
- "//third_party/icu",
- "//third_party/re2",
- ]
+if (is_android) {
+ import("//build/config/android/rules.gni")
+
+ android_resources("android_addressinput_widget_resources") {
+ custom_package = "com.android.i18n.addressinput"
+ resource_dirs = [ "src/java/res" ]
+ v14_verify_only = true
+ }
+
+ # GYP: //third_party/libaddressinput/libaddressinput.gyp:android_addressinput_widget
+ android_library("android_addressinput_widget_java") {
+ DEPRECATED_java_in_dir = "src/java/src"
+ deps = [ ":android_addressinput_widget_resources" ]
+ }
+} else {
+ # The list of files in libaddressinput.gypi.
+ gypi_values = exec_script(
+ "//build/gypi_to_gn.py",
+ [ rebase_path("src/cpp/libaddressinput.gypi") ],
+ "scope",
+ [ "src/cpp/libaddressinput.gypi" ])
+
+
+ # This target provides more complicated functionality like pinging servers
+ # for validation rules.
+ # GYP version: third_party/libaddressinput/libaddressinput.gyp:libaddressinput
+ static_library("libaddressinput") {
+ sources = rebase_path(gypi_values.libaddressinput_files, ".", "src/cpp")
+ sources += [
+ "chromium/chrome_address_validator.cc",
+ "chromium/chrome_metadata_source.cc",
+ "chromium/chrome_storage_impl.cc",
+ "chromium/fallback_data_store.cc",
+ "chromium/input_suggester.cc",
+ "chromium/string_compare.cc",
+ "chromium/trie.cc",
+ ]
+ sources -= libaddressinput_util_files
+ sources -= [
+ "src/cpp/src/util/string_compare.cc",
+ ]
+
+ configs -= [ "//build/config/compiler:chromium_code" ]
+ configs += [ "//build/config/compiler:no_chromium_code" ]
+
+ public_configs = [ ":libaddressinput_config" ]
+
+ deps = [
+ ":strings",
+ ":util",
+ "//base",
+ "//base:i18n",
+ "//third_party/icu",
+ "//third_party/re2",
+ ]
+ }
+
+ test("libaddressinput_unittests") {
+ sources = rebase_path(
+ gypi_values.libaddressinput_test_files, ".", "src/cpp")
+ sources += [
+ "chromium/addressinput_util_unittest.cc",
+ "chromium/chrome_address_validator_unittest.cc",
+ "chromium/chrome_metadata_source_unittest.cc",
+ "chromium/chrome_storage_impl_unittest.cc",
+ "chromium/fallback_data_store_unittest.cc",
+ "chromium/storage_test_runner.cc",
+ "chromium/string_compare_unittest.cc",
+ "chromium/trie_unittest.cc",
+ ]
+
+ configs -= [ "//build/config/compiler:chromium_code" ]
+ configs += [ "//build/config/compiler:no_chromium_code" ]
+
+ defines = [
+ "TEST_DATA_DIR=\"third_party/libaddressinput/src/testdata\"",
+ ]
+
+ include_dirs = [
+ "src/cpp/src",
+ ]
+
+ deps = [
+ ":libaddressinput",
+ ":strings",
+ "//base:prefs",
+ "//base/test:run_all_unittests",
+ "//net:test_support",
+ "//testing/gtest",
+ ]
+ }
}
-
-test("libaddressinput_unittests") {
- sources = rebase_path(gypi_values.libaddressinput_test_files, ".", "src/cpp")
- sources += [
- "chromium/addressinput_util_unittest.cc",
- "chromium/chrome_address_validator_unittest.cc",
- "chromium/chrome_metadata_source_unittest.cc",
- "chromium/chrome_storage_impl_unittest.cc",
- "chromium/fallback_data_store_unittest.cc",
- "chromium/storage_test_runner.cc",
- "chromium/string_compare_unittest.cc",
- "chromium/trie_unittest.cc",
- ]
-
- configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [ "//build/config/compiler:no_chromium_code" ]
-
- defines = [
- "TEST_DATA_DIR=\"third_party/libaddressinput/src/testdata\"",
- ]
-
- include_dirs = [
- "src/cpp/src",
- ]
-
- deps = [
- ":libaddressinput",
- ":strings",
- "//base:prefs",
- "//base/test:run_all_unittests",
- "//net:test_support",
- "//testing/gtest",
- ]
-}
-
-} # !is_android
« no previous file with comments | « third_party/junit/junit.gyp ('k') | third_party/libaddressinput/libaddressinput.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698