Issue 659663005: Make disassembler string tables read-only.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 659663005: Make disassembler string tables read-only. (Closed)

Created:
6 years, 2 months ago by bnoordhuis

Modified:
6 years, 2 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Visibility:
Public.

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -9 lines)			Patch
M	src/arm/disasm-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm64/disasm-arm64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/disasm-ia32.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/x64/disasm-x64.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

Benedikt Meurer

6 years, 2 months ago (2014-10-17 04:03:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 24672 (presubmit successful).