Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 659573005: DevTools: NetworkPanel: show link where resource timing is explained. (Closed)

Created:
6 years, 2 months ago by eustas
Modified:
6 years, 1 month ago
Reviewers:
vsevik, sergeyv
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: NetworkPanel: show link where resource timing is explained. BUG=403508 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184369

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -40 lines) Patch
M Source/devtools/front_end/audits/AuditFormatters.js View 1 2 3 1 chunk +1 line, -7 lines 0 comments Download
M Source/devtools/front_end/components/ShortcutsScreen.js View 1 1 chunk +1 line, -4 lines 0 comments Download
M Source/devtools/front_end/components/helpScreen.css View 1 2 3 2 chunks +1 line, -5 lines 0 comments Download
M Source/devtools/front_end/documentation/DocumentationView.js View 1 2 3 2 chunks +2 lines, -5 lines 0 comments Download
M Source/devtools/front_end/inspectorStyle.css View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M Source/devtools/front_end/main/OverridesView.js View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M Source/devtools/front_end/network/RequestTimingView.js View 1 1 chunk +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/network/networkPanel.css View 1 1 chunk +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/UISourceCodeFrame.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/WorkspaceMappingTip.js View 1 2 3 2 chunks +3 lines, -6 lines 0 comments Download
M Source/devtools/front_end/sources/sourcesView.css View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M Source/devtools/front_end/ui/UIUtils.js View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
eustas
6 years, 2 months ago (2014-10-15 07:36:39 UTC) #2
vsevik
lgtm, Consider extracting createAnchor method
6 years, 2 months ago (2014-10-22 14:31:25 UTC) #3
eustas
On 2014/10/22 14:31:25, vsevik wrote: > lgtm, > > Consider extracting createAnchor method Done. PTAL
6 years, 2 months ago (2014-10-23 14:06:37 UTC) #4
vsevik
https://codereview.chromium.org/659573005/diff/40001/Source/devtools/front_end/ui/UIUtils.js File Source/devtools/front_end/ui/UIUtils.js (right): https://codereview.chromium.org/659573005/diff/40001/Source/devtools/front_end/ui/UIUtils.js#newcode1143 Source/devtools/front_end/ui/UIUtils.js:1143: WebInspector.createDocumentationAnchor = function(article, title) I would remove Documentation aspect ...
6 years, 2 months ago (2014-10-23 15:00:03 UTC) #5
eustas
6 years, 1 month ago (2014-10-24 09:33:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659573005/60001
6 years, 1 month ago (2014-10-24 15:15:55 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-10-24 16:18:36 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as 184369

Powered by Google App Engine
This is Rietveld 408576698