Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1472)

Unified Diff: Source/devtools/front_end/sources/WorkspaceMappingTip.js

Issue 659573005: DevTools: NetworkPanel: show link where resource timing is explained. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sources/WorkspaceMappingTip.js
diff --git a/Source/devtools/front_end/sources/WorkspaceMappingTip.js b/Source/devtools/front_end/sources/WorkspaceMappingTip.js
index 7d067dd92b8a056ad2f77da006aebd1b618129d1..ad1f82509a69ebdc23f1d6602696582f763f3f75 100644
--- a/Source/devtools/front_end/sources/WorkspaceMappingTip.js
+++ b/Source/devtools/front_end/sources/WorkspaceMappingTip.js
@@ -113,10 +113,9 @@ WebInspector.WorkspaceMappingTip.prototype = {
var infobar = new WebInspector.UISourceCodeFrame.Infobar(WebInspector.UISourceCodeFrame.Infobar.Level.Info, title);
infobar.createDetailsRowMessage(WebInspector.UIString("You can map files in your workspace to the ones loaded over the network. As a result, changes made in DevTools will be persisted to disk."));
infobar.createDetailsRowMessage(WebInspector.UIString("Use context menu to establish the mapping at any time."));
- var actionLink = infobar.createDetailsRowMessage("").createChild("a");
- actionLink.href = "";
+ var actionLink = WebInspector.createAnchor("", WebInspector.UIString("Establish the mapping now..."), true);
actionLink.onclick = this._establishTheMapping.bind(this, uiSourceCode);
- actionLink.textContent = WebInspector.UIString("Establish the mapping now...");
+ infobar.createDetailsRowMessage("").appendChild(actionLink);
this._appendInfobar(uiSourceCode, infobar);
},
@@ -143,9 +142,7 @@ WebInspector.WorkspaceMappingTip.prototype = {
infobar.createDetailsRowMessage("").createChild("br");
var rowElement = infobar.createDetailsRowMessage(WebInspector.UIString("For more information on workspaces, refer to the "));
- var a = rowElement.createChild("a");
- a.textContent = "workspaces documentation";
- a.href = "https://developer.chrome.com/devtools/docs/workspaces";
+ rowElement.appendChild(WebInspector.createDocumentationAnchor("workspaces", WebInspector.UIString("workspaces documentation")));
rowElement.createTextChild(".");
uiSourceCode[WebInspector.WorkspaceMappingTip._infobarSymbol] = infobar;
uiSourceCodeFrame.attachInfobars([infobar]);
« no previous file with comments | « Source/devtools/front_end/sources/UISourceCodeFrame.js ('k') | Source/devtools/front_end/sources/sourcesView.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698