Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8080)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 659563005: Standardize usage of virtual/override/final in chrome/browser/password_manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/chrome_password_manager_client.h
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.h b/chrome/browser/password_manager/chrome_password_manager_client.h
index 10601511f8cb5f2d58f29ef4ebb4399f142a2f92..f3a2ed03e3fbc9651b59d32d2a537191a29848f7 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.h
+++ b/chrome/browser/password_manager/chrome_password_manager_client.h
@@ -37,34 +37,32 @@ class ChromePasswordManagerClient
public content::WebContentsObserver,
public content::WebContentsUserData<ChromePasswordManagerClient> {
public:
- virtual ~ChromePasswordManagerClient();
+ ~ChromePasswordManagerClient() override;
// PasswordManagerClient implementation.
- virtual bool IsAutomaticPasswordSavingEnabled() const override;
- virtual bool IsPasswordManagerEnabledForCurrentPage() const override;
- virtual bool ShouldFilterAutofillResult(
- const autofill::PasswordForm& form) override;
- virtual bool IsSyncAccountCredential(
- const std::string& username, const std::string& origin) const override;
- virtual void AutofillResultsComputed() override;
- virtual bool PromptUserToSavePassword(
+ bool IsAutomaticPasswordSavingEnabled() const override;
+ bool IsPasswordManagerEnabledForCurrentPage() const override;
+ bool ShouldFilterAutofillResult(const autofill::PasswordForm& form) override;
+ bool IsSyncAccountCredential(const std::string& username,
+ const std::string& origin) const override;
+ void AutofillResultsComputed() override;
+ bool PromptUserToSavePassword(
scoped_ptr<password_manager::PasswordFormManager> form_to_save) override;
- virtual void AutomaticPasswordSave(
- scoped_ptr<password_manager::PasswordFormManager> saved_form_manager)
- override;
- virtual void PasswordWasAutofilled(
+ void AutomaticPasswordSave(scoped_ptr<password_manager::PasswordFormManager>
+ saved_form_manager) override;
+ void PasswordWasAutofilled(
const autofill::PasswordFormMap& best_matches) const override;
- virtual void PasswordAutofillWasBlocked(
+ void PasswordAutofillWasBlocked(
const autofill::PasswordFormMap& best_matches) const override;
- virtual PrefService* GetPrefs() override;
- virtual password_manager::PasswordStore* GetPasswordStore() override;
- virtual password_manager::PasswordManagerDriver* GetDriver() override;
- virtual base::FieldTrial::Probability GetProbabilityForExperiment(
+ PrefService* GetPrefs() override;
+ password_manager::PasswordStore* GetPasswordStore() override;
+ password_manager::PasswordManagerDriver* GetDriver() override;
+ base::FieldTrial::Probability GetProbabilityForExperiment(
const std::string& experiment_name) override;
- virtual bool IsPasswordSyncEnabled() override;
- virtual void OnLogRouterAvailabilityChanged(bool router_can_be_used) override;
- virtual void LogSavePasswordProgress(const std::string& text) override;
- virtual bool IsLoggingActive() const override;
+ bool IsPasswordSyncEnabled() override;
+ void OnLogRouterAvailabilityChanged(bool router_can_be_used) override;
+ void LogSavePasswordProgress(const std::string& text) override;
+ bool IsLoggingActive() const override;
// Hides any visible generation UI.
void HidePasswordGenerationPopup();
@@ -108,7 +106,7 @@ class ChromePasswordManagerClient
friend class content::WebContentsUserData<ChromePasswordManagerClient>;
// content::WebContentsObserver overrides.
- virtual bool OnMessageReceived(const IPC::Message& message) override;
+ bool OnMessageReceived(const IPC::Message& message) override;
// Given |bounds| in the renderers coordinate system, return the same bounds
// in the screens coordinate system.
« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698