chrome/browser/password_manager/chrome_password_manager_client_unittest.cc - Issue 659563005: Standardize usage of virtual/override/final in chrome/browser/password_manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

Issue 659563005: Standardize usage of virtual/override/final in chrome/browser/password_manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.h ('k') | chrome/browser/password_manager/mock_password_store_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

diff --git a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

index a07ad6dec0d2cfc3dd04ef53f9081572ee3f579c..57438e5651ad9680a2dbb332466c4a30e38321fc 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

+++ b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

@@ -40,11 +40,10 @@ class TestChromePasswordManagerClient : public ChromePasswordManagerClient {

explicit TestChromePasswordManagerClient(content::WebContents* web_contents)

: ChromePasswordManagerClient(web_contents, NULL),

is_sync_account_credential_(false) {}

- virtual ~TestChromePasswordManagerClient() {}

+ ~TestChromePasswordManagerClient() override {}

- virtual bool IsSyncAccountCredential(

- const std::string& username,

- const std::string& origin) const override {

+ bool IsSyncAccountCredential(const std::string& username,

+ const std::string& origin) const override {

return is_sync_account_credential_;

}