DescriptionAllow conditional lit tests in Subzero, based on build flags.
Adds conditionality to lit tests in two ways:
1) Allows the use of "; REQUIRES: XXX" lines in lit tests. In this
case, the tests defined by the file are only run if all REQUIRES are
met.
2) Allows the conditional running of RUN commands, based on build
flags. This comes in two subforms. There are predefined %ifX commands
that run the command defined by remaining arguments, if the
corresponding %X2i command is applicable. Alternatively, one can use
%if with explicit '--att' arguments to define what conditions should
be checked.
In any case, unlike REQUIRES, the %if commands RUN all the time, but
simply generate empty output, rather then output defined by the
following command, if the condition is not met. These latter tests are
useful when the same input is to be tested under different conditions,
since the REQUIRES form does not allow this.
Note that m2i, p2i, l2i, and lc2i are also conditionally controlled,
so that they do nothing if the build did not construct the appropriate
Subzero translator.
This CL replaces https://codereview.chromium.org/644143002
BUG=None
R=jvoung@chromium.org, stichnot@chromium.org
Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=b262c5e0b110e63ec706213adf0af202274c442e
Patch Set 1 #
Total comments: 24
Patch Set 2 : Fix issues raised by stichnot in patch set 1. #Patch Set 3 : Fix tests to handle MINIMAL builds. #
Total comments: 28
Patch Set 4 : Fix issues in patch set 3. #
Total comments: 23
Patch Set 5 : Fix issues in patch set 4. #Patch Set 6 : Fix nits. #
Total comments: 9
Patch Set 7 : Fix issues in patch set 6. #Patch Set 8 : Use REQUIRES when appropriate in lit tests. #
Total comments: 6
Patch Set 9 : Fix issues in patch set 8. #
Total comments: 10
Patch Set 10 : Fix LLVM (i.e. trybot) builds to handle subzero. #
Total comments: 2
Patch Set 11 : Add -Wno-error=unused-parameter #
Messages
Total messages: 21 (1 generated)
|