tests_lit/llvm2ice_tests/fp.pnacl.ll - Issue 659513005: Allow conditional lit tests in Subzero, based on build flags.

Side by Side Diff: tests_lit/llvm2ice_tests/fp.pnacl.ll

Issue 659513005: Allow conditional lit tests in Subzero, based on build flags. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix tests to handle MINIMAL builds. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« tests_lit/lit.cfg ('K') | « tests_lit/llvm2ice_tests/ebp_args.ll ('k') | tests_lit/llvm2ice_tests/global.ll » ('j') | tests_lit/llvm2ice_tests/globalrelocs.ll » ('J')

OLD	NEW
1 ; This tries to be a comprehensive test of f32 and f64 operations.	1 ; This tries to be a comprehensive test of f32 and f64 operations.

2 ; The CHECK lines are only checking for basic instruction patterns	2 ; The CHECK lines are only checking for basic instruction patterns

3 ; that should be present regardless of the optimization level, so	3 ; that should be present regardless of the optimization level, so

4 ; there are no special OPTM1 match lines.	4 ; there are no special OPTM1 match lines.

5	5

6 ; TODO(jvoung): fix extra "CALLTARGETS" run. The llvm-objdump symbolizer	6 ; TODO(jvoung): fix extra "CALLTARGETS" run. The llvm-objdump symbolizer

7 ; doesn't know how to symbolize non-section-local functions.	7 ; doesn't know how to symbolize non-section-local functions.

8 ; The newer LLVM 3.6 one does work, but watch out for other bugs.	8 ; The newer LLVM 3.6 one does work, but watch out for other bugs.

9	9

	10 ; REQUIRES: x86-32
	jvoung (off chromium) 2014/10/15 21:57:06 Any reason this is considered REQUIRES: x86-32 vs Any reason this is considered REQUIRES: x86-32 vs say, ebp_args.ll ? This one seems like it could be extended to have more arches, while the ebp sounds more specific to x86-32 (though could apply to anything with a frame pointer, with some changes). Which part of the CL enables the REQUIRES: syntax? Karl 2014/10/16 16:51:48 The point of this change was to show that requires Show quoted text On 2014/10/15 21:57:06, jvoung wrote: > Any reason this is considered REQUIRES: x86-32 vs say, ebp_args.ll ? > > This one seems like it could be extended to have more arches, while the ebp > sounds more specific to x86-32 (though could apply to anything with a frame > pointer, with some changes). > > Which part of the CL enables the REQUIRES: syntax? The point of this change was to show that requires works. Since it appears confusing, I will remove it. However, the point is that in Subzero/tests_lit/lit.cfg (line 74) updates config.available_features to include all (target) build attributes. The syntax for REQUIRES syntax is always enabled, and uses the available_features attribute to define what symbols can be used in REQUIRES. jvoung (off chromium) 2014/10/20 17:36:00 A good example might be tests_lit/llvm2ice_tests/a Show quoted text On 2014/10/16 16:51:48, Karl wrote: > On 2014/10/15 21:57:06, jvoung wrote: > > Any reason this is considered REQUIRES: x86-32 vs say, ebp_args.ll ? > > > > This one seems like it could be extended to have more arches, while the ebp > > sounds more specific to x86-32 (though could apply to anything with a frame > > pointer, with some changes). > > > > Which part of the CL enables the REQUIRES: syntax? > > The point of this change was to show that requires works. Since it appears > confusing, I will remove it. However, the point is that in > Subzero/tests_lit/lit.cfg (line 74) updates config.available_features to include > all (target) build attributes. The syntax for REQUIRES syntax is always enabled, > and uses the available_features attribute to define what symbols can be used in > REQUIRES. A good example might be tests_lit/llvm2ice_tests/addr-opt-multi-def-var.ll. That requires some logging from "--verbose addropt" to work. I guess that could also be done with the %if. Karl 2014/10/20 21:00:42 Added "REQUIRES: x86-32" to test file, since it is Show quoted text On 2014/10/20 17:36:00, jvoung wrote: > On 2014/10/16 16:51:48, Karl wrote: > > On 2014/10/15 21:57:06, jvoung wrote: > > > Any reason this is considered REQUIRES: x86-32 vs say, ebp_args.ll ? > > > > > > This one seems like it could be extended to have more arches, while the ebp > > > sounds more specific to x86-32 (though could apply to anything with a frame > > > pointer, with some changes). > > > > > > Which part of the CL enables the REQUIRES: syntax? > > > > The point of this change was to show that requires works. Since it appears > > confusing, I will remove it. However, the point is that in > > Subzero/tests_lit/lit.cfg (line 74) updates config.available_features to > include > > all (target) build attributes. The syntax for REQUIRES syntax is always > enabled, > > and uses the available_features attribute to define what symbols can be used > in > > REQUIRES. > > > A good example might be tests_lit/llvm2ice_tests/addr-opt-multi-def-var.ll. That > requires some logging from "--verbose addropt" to work. I guess that could also > be done with the %if. Added "REQUIRES: x86-32" to test file, since it is part of the x8632 lowering code.
10 ; RUN: %p2i -i %s --args -O2 --verbose none \	11 ; RUN: %p2i -i %s --args -O2 --verbose none \

11 ; RUN: \| FileCheck --check-prefix=CALLTARGETS %s	12 ; RUN: \| FileCheck --check-prefix=CALLTARGETS %s

12 ; RUN: %p2i -i %s --args -O2 --verbose none \	13 ; RUN: %p2i -i %s --args -O2 --verbose none \

13 ; RUN: \| llvm-mc -triple=i686-none-nacl -x86-asm-syntax=intel -filetype=obj \	14 ; RUN: \| llvm-mc -triple=i686-none-nacl -x86-asm-syntax=intel -filetype=obj \

14 ; RUN: \| llvm-objdump -d --symbolize -x86-asm-syntax=intel - \| FileCheck %s	15 ; RUN: \| llvm-objdump -d --symbolize -x86-asm-syntax=intel - \| FileCheck %s

15 ; RUN: %p2i -i %s --args -Om1 --verbose none \	16 ; RUN: %p2i -i %s --args -Om1 --verbose none \

16 ; RUN: \| llvm-mc -triple=i686-none-nacl -x86-asm-syntax=intel -filetype=obj \	17 ; RUN: \| llvm-mc -triple=i686-none-nacl -x86-asm-syntax=intel -filetype=obj \

17 ; RUN: \| llvm-objdump -d --symbolize -x86-asm-syntax=intel - \| FileCheck %s	18 ; RUN: \| llvm-objdump -d --symbolize -x86-asm-syntax=intel - \| FileCheck %s

18 ; RUN: %p2i -i %s --args --verbose none \| FileCheck --check-prefix=ERRORS %s	19 ; RUN: %p2i -i %s --args --verbose none \| FileCheck --check-prefix=ERRORS %s

19	20

(...skipping 1207 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1227 %cmp = fcmp olt double %a, %b	1228 %cmp = fcmp olt double %a, %b

1228 %cond = select i1 %cmp, double %a, double %b	1229 %cond = select i1 %cmp, double %a, double %b

1229 ret double %cond	1230 ret double %cond

1230 }	1231 }

1231 ; CHECK-LABEL: selectDoubleVarVar	1232 ; CHECK-LABEL: selectDoubleVarVar

1232 ; CHECK: ucomisd	1233 ; CHECK: ucomisd

1233 ; CHECK: ja {{[0-9]}}	1234 ; CHECK: ja {{[0-9]}}

1234 ; CHECK: fld	1235 ; CHECK: fld

1235	1236

1236 ; ERRORS-NOT: ICE translation error	1237 ; ERRORS-NOT: ICE translation error

OLD	NEW