Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 659513002: [NaCl SDK] nacl_io: ignore mode bits when creating files. (Closed)

Created:
6 years, 2 months ago by binji
Modified:
6 years, 2 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] nacl_io: ignore mode bits when creating files. It is legal to create a file with mode bits that conflict with the open flags, e.g.: open("foo", O_WRONLY | O_CREAT, 0444); BUG=none R=sbc@chromium.org Committed: https://crrev.com/f5f1c81f5f1b55516d36e40288db0e7d62e88585 Cr-Commit-Position: refs/heads/master@{#299919}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M native_client_sdk/src/libraries/nacl_io/kernel_handle.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/kernel_proxy_test.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
binji
6 years, 2 months ago (2014-10-14 14:49:06 UTC) #1
Sam Clegg
Interesting. Did not know that. LGTM.
6 years, 2 months ago (2014-10-14 16:53:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659513002/1
6 years, 2 months ago (2014-10-16 17:03:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 17:49:45 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 17:50:49 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5f1c81f5f1b55516d36e40288db0e7d62e88585
Cr-Commit-Position: refs/heads/master@{#299919}

Powered by Google App Engine
This is Rietveld 408576698