Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 659463002: Add myself (vabr) to autofill/OWNERS for passwords (Closed)

Created:
6 years, 2 months ago by vabr (Chromium)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add myself (vabr) to autofill/OWNERS for passwords This should match vabr being already in components/password_manager/OWNERS. BUG=None NOTRY=True Committed: https://crrev.com/26c1c52ff4376cb78f9ffb6098f237d80952aa59 Cr-Commit-Position: refs/heads/master@{#299868}

Patch Set 1 #

Total comments: 3

Patch Set 2 : per-file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M components/autofill/OWNERS View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
vabr (Chromium)
Garrett, Thanks for your suggestion in https://codereview.chromium.org/649583003/#msg6 (but let me know if I misunderstood "this ...
6 years, 2 months ago (2014-10-14 08:36:43 UTC) #2
Garrett Casto
lgtm
6 years, 2 months ago (2014-10-14 18:07:38 UTC) #4
Ilya Sherman
FWIW, [ http://crbug.com/423445 ] suggests that this might not currently work (unless Garrett really isn't ...
6 years, 2 months ago (2014-10-14 20:37:17 UTC) #5
Garrett Casto
https://codereview.chromium.org/659463002/diff/1/components/autofill/OWNERS File components/autofill/OWNERS (right): https://codereview.chromium.org/659463002/diff/1/components/autofill/OWNERS#newcode6 components/autofill/OWNERS:6: vabr@chromium.org On 2014/10/14 20:37:17, Ilya Sherman wrote: > Is ...
6 years, 2 months ago (2014-10-14 20:45:53 UTC) #6
vabr (Chromium)
Ilya, Garrett, PTAL at the per-file version. Cheers, Vaclav https://codereview.chromium.org/659463002/diff/1/components/autofill/OWNERS File components/autofill/OWNERS (right): https://codereview.chromium.org/659463002/diff/1/components/autofill/OWNERS#newcode6 components/autofill/OWNERS:6: ...
6 years, 2 months ago (2014-10-15 10:34:01 UTC) #7
Ilya Sherman
LGTM. Thanks!
6 years, 2 months ago (2014-10-15 21:40:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659463002/20001
6 years, 2 months ago (2014-10-16 08:22:17 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-16 08:22:44 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 08:23:32 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/26c1c52ff4376cb78f9ffb6098f237d80952aa59
Cr-Commit-Position: refs/heads/master@{#299868}

Powered by Google App Engine
This is Rietveld 408576698