components/autofill/OWNERS - Issue 659463002: Add myself (vabr) to autofill/OWNERS for passwords

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/autofill/OWNERS

Issue 659463002: Add myself (vabr) to autofill/OWNERS for passwords (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 estade@chromium.org	1 estade@chromium.org

2 isherman@chromium.org	2 isherman@chromium.org

3	3

4 # Owner for password autofill/generation only.	4 # Owners for password autofill/generation only.

5 gcasto@chromium.org	5 gcasto@chromium.org

	6 vabr@chromium.org
	Ilya Sherman 2014/10/14 20:37:17 Is it viable to add you both as per-file OWNERS in Is it viable to add you both as per-file OWNERS instead, now that the component's structure is fairly stable? Garrett Casto 2014/10/14 20:45:53 I guess all the password related files have passwo Show quoted text On 2014/10/14 20:37:17, Ilya Sherman wrote: > Is it viable to add you both as per-file OWNERS instead, now that the > component's structure is fairly stable I guess all the password related files have password in their name, so maybe per-file password=... Might be confusing though. Long term we should finish untangling these two components, but it's not likely to happen this quarter. vabr (Chromium) 2014/10/15 10:34:01 I added per-file for password and also (content/ Show quoted text On 2014/10/14 20:45:53, Garrett Casto wrote: > On 2014/10/14 20:37:17, Ilya Sherman wrote: > > Is it viable to add you both as per-file OWNERS instead, now that the > > component's structure is fairly stable > > I guess all the password related files have password in their name, so maybe > > per-file password=... > > Might be confusing though. Long term we should finish untangling these two > components, but it's not likely to happen this quarter. I added per-file for password and also (content/common/)autofill_param_traits_macros.h, which is relevant for PasswordForm (and is not covered by the security team set of OWNERS).
OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »