Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1678)

Unified Diff: Source/devtools/front_end/main/Main.js

Issue 659403006: DevTools: do not consider ? a shortcut while editing. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/main/Main.js
diff --git a/Source/devtools/front_end/main/Main.js b/Source/devtools/front_end/main/Main.js
index 4a0ff2bc01c6a587253d75dd8bbf95611992edc1..0eac60aa1654b480cab3d9832c78fb2b5fb83c34 100644
--- a/Source/devtools/front_end/main/Main.js
+++ b/Source/devtools/front_end/main/Main.js
@@ -384,7 +384,12 @@ WebInspector.Main.prototype = {
_documentClick: function(event)
{
- var target = event.deepElementFromPoint();
+ var target = event.target;
+ if (target.shadowRoot)
+ target = event.deepElementFromPoint();
+ if (!target)
+ return;
+
var anchor = target.enclosingNodeOrSelfWithNodeName("a");
if (!anchor || !anchor.href)
return;
@@ -402,7 +407,7 @@ WebInspector.Main.prototype = {
function followLink()
{
- if (WebInspector.isBeingEdited(target))
+ if (WebInspector.isEditing())
vsevik 2014/10/21 12:59:56 This won't work (probably)
pfeldman 2014/10/21 13:01:55 Done.
return;
if (WebInspector.openAnchorLocationRegistry.dispatch({ url: anchor.href, lineNumber: anchor.lineNumber}))
return;

Powered by Google App Engine
This is Rietveld 408576698