Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Unified Diff: Source/devtools/front_end/elements/ElementsTreeOutline.js

Issue 659403006: DevTools: do not consider ? a shortcut while editing. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/main/Main.js » ('j') | Source/devtools/front_end/main/Main.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/elements/ElementsTreeOutline.js
diff --git a/Source/devtools/front_end/elements/ElementsTreeOutline.js b/Source/devtools/front_end/elements/ElementsTreeOutline.js
index 3836821243ad54a0ced0166df628392447ffc843..3cfc554cf49f7c1798105aa173e33a35d7e0502e 100644
--- a/Source/devtools/front_end/elements/ElementsTreeOutline.js
+++ b/Source/devtools/front_end/elements/ElementsTreeOutline.js
@@ -42,10 +42,10 @@ WebInspector.ElementsTreeOutline = function(target, omitRootDOMNode, selectEnabl
this._domModel = target.domModel;
var element = createElement("div");
- this._shadowRoot = element.createShadowRoot();
- this._shadowRoot.appendChild(WebInspector.View.createStyleElement("elementsTreeOutline.css"));
+ var shadowRoot = element.createShadowRoot();
+ shadowRoot.appendChild(WebInspector.View.createStyleElement("elementsTreeOutline.css"));
- var outlineDisclosureElement = this._shadowRoot.createChild("div", "component-root outline-disclosure source-code");
+ var outlineDisclosureElement = shadowRoot.createChild("div", "component-root outline-disclosure source-code");
this._element = outlineDisclosureElement.createChild("ol", "elements-tree-outline");
this._element.addEventListener("mousedown", this._onmousedown.bind(this), false);
this._element.addEventListener("mousemove", this._onmousemove.bind(this), false);
@@ -232,8 +232,7 @@ WebInspector.ElementsTreeOutline.prototype = {
return;
// Do not interfere with text editing.
- var currentFocusElement = WebInspector.currentFocusElement();
- if (currentFocusElement && WebInspector.isBeingEdited(currentFocusElement))
+ if (WebInspector.isEditing())
return;
var targetNode = this.selectedDOMNode();
@@ -295,8 +294,7 @@ WebInspector.ElementsTreeOutline.prototype = {
handlePasteKeyboardEvent: function(event)
{
// Do not interfere with text editing.
- var currentFocusElement = WebInspector.currentFocusElement();
- if (currentFocusElement && WebInspector.isBeingEdited(currentFocusElement))
+ if (WebInspector.isEditing())
return;
var targetNode = this.selectedDOMNode();
« no previous file with comments | « no previous file | Source/devtools/front_end/main/Main.js » ('j') | Source/devtools/front_end/main/Main.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698