Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 65933002: Mojo: Unify the disparate source and header files into 3 (Closed)

Created:
7 years, 1 month ago by DaveMoore
Modified:
7 years, 1 month ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Unify the disparate source and header files into 3 - service.h, service.cc, service_internal.h BUG=None TEST=None (coming soon) R=darin@chromium.org, darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233915

Patch Set 1 #

Patch Set 2 : Forgot to add templates #

Patch Set 3 : Mistaken /n's #

Unified diffs Side-by-side diffs Delta from patch set Stats (+338 lines, -537 lines) Patch
D mojo/public/bindings/generators/cpp_templates/interface.h-template View 1 chunk +0 lines, -20 lines 0 comments Download
A mojo/public/bindings/generators/cpp_templates/interface_declaration View 1 1 chunk +4 lines, -0 lines 0 comments Download
A mojo/public/bindings/generators/cpp_templates/interface_definition View 1 1 chunk +6 lines, -0 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/interface_proxy.cc-template View 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/interface_proxy.h-template View 1 chunk +0 lines, -25 lines 0 comments Download
A mojo/public/bindings/generators/cpp_templates/interface_proxy_declaration View 1 1 chunk +9 lines, -0 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/interface_serialization.cc-template View 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/interface_serialization.h-template View 1 chunk +0 lines, -32 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/interface_stub.cc-template View 1 chunk +0 lines, -18 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/interface_stub.h-template View 1 chunk +0 lines, -20 lines 0 comments Download
M mojo/public/bindings/generators/cpp_templates/interface_stub_case View 1 chunk +3 lines, -3 lines 0 comments Download
A mojo/public/bindings/generators/cpp_templates/interface_stub_declaration View 1 1 chunk +4 lines, -0 lines 0 comments Download
A mojo/public/bindings/generators/cpp_templates/interface_stub_definition View 1 1 chunk +6 lines, -0 lines 0 comments Download
A mojo/public/bindings/generators/cpp_templates/module.cc-template View 1 chunk +39 lines, -0 lines 0 comments Download
A + mojo/public/bindings/generators/cpp_templates/module.h-template View 1 chunk +6 lines, -2 lines 0 comments Download
A + mojo/public/bindings/generators/cpp_templates/module_internal.h-template View 1 chunk +7 lines, -9 lines 0 comments Download
A mojo/public/bindings/generators/cpp_templates/params_definition View 1 1 chunk +25 lines, -0 lines 0 comments Download
A mojo/public/bindings/generators/cpp_templates/params_serialization View 1 1 chunk +18 lines, -0 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/struct.cc-template View 1 chunk +0 lines, -11 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/struct.h-template View 1 chunk +0 lines, -20 lines 0 comments Download
A + mojo/public/bindings/generators/cpp_templates/struct_definition View 1 1 chunk +1 line, -1 line 0 comments Download
D mojo/public/bindings/generators/cpp_templates/struct_implementation View 1 chunk +0 lines, -9 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/struct_serialization.cc-template View 1 chunk +0 lines, -34 lines 0 comments Download
D mojo/public/bindings/generators/cpp_templates/struct_serialization.h-template View 1 chunk +0 lines, -31 lines 0 comments Download
A mojo/public/bindings/generators/cpp_templates/struct_serialization_definition View 1 1 chunk +16 lines, -0 lines 0 comments Download
A + mojo/public/bindings/generators/cpp_templates/struct_serialization_traits View 1 2 chunks +0 lines, -21 lines 0 comments Download
M mojo/public/bindings/generators/mojom_cpp_generator.py View 1 2 11 chunks +180 lines, -228 lines 0 comments Download
M mojo/public/bindings/mojo_idl.py View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/public/bindings/parser/mojo_translate.py View 3 chunks +8 lines, -7 lines 0 comments Download
M mojo/public/bindings/sample/sample_service.mojom View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
DaveMoore
7 years, 1 month ago (2013-11-08 00:10:27 UTC) #1
DaveMoore
Forgot to add templates
7 years, 1 month ago (2013-11-08 00:38:30 UTC) #2
DaveMoore
Mistaken /n's
7 years, 1 month ago (2013-11-08 00:43:40 UTC) #3
darin (slow to review)
LGTM
7 years, 1 month ago (2013-11-08 00:49:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/65933002/60001
7 years, 1 month ago (2013-11-08 01:07:58 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-08 01:46:05 UTC) #6
DaveMoore
7 years, 1 month ago (2013-11-08 16:25:12 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 manually as r233915 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698