Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: base/android/linker/linker_jni.cc

Issue 659313005: Tidy logcat message on test for mmap from apk. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Rename status variable. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/linker/linker_jni.cc
diff --git a/base/android/linker/linker_jni.cc b/base/android/linker/linker_jni.cc
index 81c664729df0191b9e16d47545e0b7c8240b884d..a545c528ed336e44953138c9a51f8ad5647a1bf4 100644
--- a/base/android/linker/linker_jni.cc
+++ b/base/android/linker/linker_jni.cc
@@ -599,19 +599,18 @@ jboolean CheckLibraryLoadFromApkSupport(JNIEnv* env, jclass clazz,
__FUNCTION__, apkfile_name_c_str);
void* address = mmap(NULL, PAGE_SIZE, PROT_EXEC, MAP_PRIVATE, fd, 0);
- jboolean success;
+ jboolean status;
petrcermak 2014/10/20 13:11:49 Does it make sense to say that the current status
if (address == MAP_FAILED) {
- success = false;
+ status = false;
} else {
- success = true;
+ status = true;
munmap(address, PAGE_SIZE);
}
close(fd);
- LOG_INFO(" %ssupported\n", success ? "" : "NOT ");
- return success;
-
+ LOG_INFO("%s: %s\n", __FUNCTION__, status ? "Supported" : "NOT supported");
+ return status;
}
const JNINativeMethod kNativeMethods[] = {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698