Tidy logcat message on test for mmap from apk.

base/android/linker/linker_jni.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This is the Android-specific Chromium linker, a tiny shared library
 // implementing a custom dynamic linker that can be used to load the
 // real Chromium libraries (e.g. libcontentshell.so).
 
 // The main point of this linker is to be able to share the RELRO
 // section of libcontentshell.so (or equivalent) between the browser and
@@ skipping 581 matching lines @@
   if (fd == -1) {
     LOG_ERROR("%s: Failed to open %s\n", __FUNCTION__, apkfile_name_c_str);
     return false;
   }
 
   LOG_INFO(
       "%s: Memory mapping the first page of %s with executable permissions\n",
       __FUNCTION__, apkfile_name_c_str);
   void* address = mmap(NULL, PAGE_SIZE, PROT_EXEC, MAP_PRIVATE, fd, 0);
 
-  jboolean success;
+  jboolean status;

[petrcermak, 2014/10/20 13:11:49]

Does it make sense to say that the current status is "true" or "false"? How
about about "jboolean supported" instead?

   if (address == MAP_FAILED) {
-    success = false;
+    status = false;
   } else {
-    success = true;
+    status = true;
     munmap(address, PAGE_SIZE);
   }
 
   close(fd);
 
-  LOG_INFO("  %ssupported\n", success ? "" : "NOT ");
-  return success;
-
+  LOG_INFO("%s: %s\n", __FUNCTION__, status ? "Supported" : "NOT supported");
+  return status;
 }
 
 const JNINativeMethod kNativeMethods[] = {
     {"nativeLoadLibrary",
      "("
      "Ljava/lang/String;"
      "J"
      "Lorg/chromium/base/library_loader/Linker$LibInfo;"
      ")"
      "Z",
@@ skipping 88 matching lines @@
   crazy_context_t* context = GetCrazyContext();
   crazy_context_set_java_vm(context, vm, JNI_VERSION_1_4);
 
   // Register the function that the crazy linker can call to post code
   // for later execution.
   crazy_context_set_callback_poster(context, &PostForLaterExecution, NULL);
 
   LOG_INFO("%s: Done", __FUNCTION__);
   return JNI_VERSION_1_4;
 }