Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 659313005: Tidy logcat message on test for mmap from apk. (Closed)

Created:
6 years, 2 months ago by simonb (inactive)
Modified:
6 years, 2 months ago
Reviewers:
rmcilroy, petrcermak
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Tidy logcat message on test for mmap from apk. Prefix CheckLibraryLoadFromApkSupport()'s result log line with __FUNCTION__, for logging clarity. Remove stray empty line. BUG=390618 Committed: https://crrev.com/1fcf60de91ec1057a0f1bbfc0f56e62c8f145505 Cr-Commit-Position: refs/heads/master@{#300260}

Patch Set 1 #

Patch Set 2 : Rename status variable. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M base/android/linker/linker_jni.cc View 1 1 chunk +5 lines, -6 lines 1 comment Download

Messages

Total messages: 9 (2 generated)
simonb (inactive)
6 years, 2 months ago (2014-10-17 17:49:10 UTC) #2
rmcilroy
lgtm, thanks.
6 years, 2 months ago (2014-10-20 13:00:05 UTC) #3
rmcilroy
lgtm, thanks.
6 years, 2 months ago (2014-10-20 13:00:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659313005/20001
6 years, 2 months ago (2014-10-20 13:04:56 UTC) #6
petrcermak
https://codereview.chromium.org/659313005/diff/20001/base/android/linker/linker_jni.cc File base/android/linker/linker_jni.cc (right): https://codereview.chromium.org/659313005/diff/20001/base/android/linker/linker_jni.cc#newcode602 base/android/linker/linker_jni.cc:602: jboolean status; Does it make sense to say that ...
6 years, 2 months ago (2014-10-20 13:11:49 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-20 13:25:46 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 13:27:25 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1fcf60de91ec1057a0f1bbfc0f56e62c8f145505
Cr-Commit-Position: refs/heads/master@{#300260}

Powered by Google App Engine
This is Rietveld 408576698