Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(44)

Issue 6592065: Pass around preferred language to font fallback selection. (Closed)

Created:
9 years, 8 months ago by kochi
Modified:
9 years, 5 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Pass around preferred language to font fallback selection. See also https://bugs.webkit.org/show_bug.cgi?id=55453 for WebKit side of the change. BUG=chromium-os:11699 TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77118

Patch Set 1 #

Patch Set 2 : Only use existing interface until WebKit side of change lands. #

Patch Set 3 : Remove unnecessary LOG(). #

Patch Set 4 : Pass the defualt locale as "", not NULL to prevent runtime error. #

Patch Set 5 : Fix the reference bug number of webkit bugzilla in comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -5 lines) Patch
M chrome/renderer/renderer_main.cc View 1 2 3 chunks +14 lines, -0 lines 0 comments Download
M chrome/renderer/renderer_sandbox_support_linux.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/renderer/renderer_sandbox_support_linux.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/renderer/renderer_webkitclient_impl.cc View 1 2 3 4 3 chunks +21 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_sandbox_host_linux.cc View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kochi
9 years, 8 months ago (2011-03-01 11:11:25 UTC) #1
Takayoshi Kochi (Google)
Ping? On Tue, Mar 1, 2011 at 8:11 PM, <kochi@chromium.org> wrote: > Reviewers: Jungshik Shin, ...
9 years, 7 months ago (2011-03-02 13:21:17 UTC) #2
jungshik at Google
LGTM ! Thanks.
9 years, 7 months ago (2011-03-03 01:26:10 UTC) #3
kochi
Changed the comment/parameter name to align with https://bugs.webkit.org/show_bug.cgi?id=55453 review (preferred_language -> preferred_locale). So as not ...
9 years, 7 months ago (2011-03-03 11:44:18 UTC) #4
jungshik at Google
LGTM On 2011/03/03 11:44:18, Takayoshi Kochi wrote: > Changed the comment/parameter name to align with ...
9 years, 7 months ago (2011-03-03 21:08:09 UTC) #5
kochi
9 years, 7 months ago (2011-03-05 04:06:25 UTC) #6
It got some error in trybot and found that passing NULL for the locale
made some trouble.  Substituted with "".  Now it passes all trybots.

I'll be submitting this on Monday JST.

On 2011/03/03 21:08:09, Jungshik Shin wrote:
> LGTM 
> On 2011/03/03 11:44:18, Takayoshi Kochi wrote:
> > Changed the comment/parameter name to align with
> > https://bugs.webkit.org/show_bug.cgi?id=55453 review
> > (preferred_language -> preferred_locale).
> > 
> > So as not to break WebKit<->Chromium interface, I would like to
> > commit this first, then WebKit 55453.
> > Once WebKit 55453 lands, I would change Chromium side again.
> > I marked TODO(kochi) where changes are necessary (2 locations).
> > 
> > I changed accordingly for above.  Could you take another
> > look?
> > 
> > Thanks.

Powered by Google App Engine
This is Rietveld 408576698