Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 6592053: Create bootstub signing utility. (Closed)

Created:
9 years, 9 months ago by robotboy
Modified:
9 years, 7 months ago
Reviewers:
sjg, vb, Che-Liang Chiou
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Create bootstub signing utility. This tool uses cbootimage to sign a bootstub firmware image. This makes calling cbootimage from a number of scripts easier. BUG=chromium-os:11981 TEST=run cros_sign_bootstub and sign a recovery image and write it to a board using cros_write_firmware which hasn't been submitted yet. Change-Id: I4b3a9c763d0659d0244eb4d6ed2f0a38154d00c4 This CL depends on: http://codereview.chromium.org/6591056/ Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4a9554c

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -0 lines) Patch
A host/cros_sign_bootstub View 1 chunk +88 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
robotboy
9 years, 9 months ago (2011-02-28 23:39:30 UTC) #1
vb
LGTM with a few nits to your discretion. In the CL description: s/This is makes/This ...
9 years, 9 months ago (2011-02-28 23:54:44 UTC) #2
robotboy
http://codereview.chromium.org/6592053/diff/1/host/cros_sign_bootstub File host/cros_sign_bootstub (right): http://codereview.chromium.org/6592053/diff/1/host/cros_sign_bootstub#newcode77 host/cros_sign_bootstub:77: mkdir -p "${FLAGS_config}" On 2011/02/28 23:54:44, vb wrote: > ...
9 years, 9 months ago (2011-03-01 00:03:40 UTC) #3
Che-Liang Chiou
9 years, 9 months ago (2011-03-01 01:36:30 UTC) #4
LGTM.

On 2011/03/01 00:03:40, robotboy wrote:
> http://codereview.chromium.org/6592053/diff/1/host/cros_sign_bootstub
> File host/cros_sign_bootstub (right):
> 
>
http://codereview.chromium.org/6592053/diff/1/host/cros_sign_bootstub#newcode77
> host/cros_sign_bootstub:77: mkdir -p "${FLAGS_config}"
> On 2011/02/28 23:54:44, vb wrote:
> > It would be cleaner to remove the directory on exit if it did not exist on
> > entry.
> > 
> > OTOH it would be good to be able to request to keep the config file.
> 
> Yup, the intent here is that if you don't specify anything on the command line
> (no --config option) then the config is generated in a /tmp/tmp.XXXXXXX
> directory and cleaned up after the run.  If you do pass a --config option on
the
> command line then the config file is retained in that directory.

Powered by Google App Engine
This is Rietveld 408576698