Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 6592007: Port revision 6934 and 6993 (plus fix from 6935) to the 3.0 branch. (Closed)

Created:
9 years, 10 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev, Søren Thygesen Gjesse
Visibility:
Public.

Description

Port revision 6934 (plus fix from 6935) and refactoring in revision 6993 to the 3.0 branch. Committed: http://code.google.com/p/v8/source/detail?r=7156

Patch Set 1 #

Total comments: 4

Patch Set 2 : Include refactoring of HandleCell. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+462 lines, -300 lines) Patch
M src/array.js View 1 chunk +0 lines, -1 line 0 comments Download
M src/handles.h View 1 4 chunks +38 lines, -12 lines 0 comments Download
M src/handles-inl.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 2 chunks +374 lines, -283 lines 0 comments Download
M src/version.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/array-concat.js View 2 chunks +43 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Lasse Reichstein
9 years, 10 months ago (2011-02-25 12:37:26 UTC) #1
Erik Corry
LGTM, but please talk to Mads before committing.
9 years, 10 months ago (2011-02-25 12:42:02 UTC) #2
Mads Ager (chromium)
No reason for another handle abstraction. We can escape handles to the outer handle scope. ...
9 years, 9 months ago (2011-02-28 08:11:20 UTC) #3
Lasse Reichstein
Please recheck.
9 years, 9 months ago (2011-03-09 12:43:06 UTC) #4
Erik Corry
LGTM
9 years, 9 months ago (2011-03-09 14:06:42 UTC) #5
Lasse Reichstein
9 years, 9 months ago (2011-03-10 14:07:45 UTC) #6
FYI.

Powered by Google App Engine
This is Rietveld 408576698