Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: components/OWNERS

Issue 658973003: Update Autofill component ownership to avoid bugs in OWNERS file parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/OWNERS » ('j') | components/autofill/OWNERS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/OWNERS
diff --git a/components/OWNERS b/components/OWNERS
index 220ef1011aafb61f99fe70b94704cea3c2827f55..ed713276d9d95e7810c2af26ee9ece64b17a620a 100644
--- a/components/OWNERS
+++ b/components/OWNERS
@@ -3,8 +3,11 @@ caitkp@chromium.org
erikwright@chromium.org
jochen@chromium.org
-per-file autofill*=estade@chromium.org
-per-file autofill*=isherman@chromium.org
+# Can not match autofill* due to crbug.com/397984
+per-file autofill.gypi=estade@chromium.org
+per-file autofill.gypi=isherman@chromium.org
+per-file autofill_strings.grdp=estade@chromium.org
+per-file autofill_strings.grpd=isherman@chromium.org
Ilya Sherman 2014/10/17 22:02:57 nit: "grpd" -> "grdp"
Ilya Sherman 2014/10/17 22:02:57 Also, I wonder if we can move this file to live wi
Garrett Casto 2014/10/17 23:17:00 Done.
Garrett Casto 2014/10/17 23:17:00 Acknowledged.
blundell 2014/10/20 11:31:07 +1, I think it's reasonable to have all the foo-re
tfarina 2014/10/21 15:17:03 There are some complications in doing that. But I
per-file bookmarks.gypi=sky@chromium.org
« no previous file with comments | « no previous file | components/autofill/OWNERS » ('j') | components/autofill/OWNERS » ('J')

Powered by Google App Engine
This is Rietveld 408576698