components/OWNERS - Issue 658973003: Update Autofill component ownership to avoid bugs in OWNERS file parsing

Side by Side Diff: components/OWNERS

Issue 658973003: Update Autofill component ownership to avoid bugs in OWNERS file parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 blundell@chromium.org	1 blundell@chromium.org

2 caitkp@chromium.org	2 caitkp@chromium.org

3 erikwright@chromium.org	3 erikwright@chromium.org

4 jochen@chromium.org	4 jochen@chromium.org

5	5

6 per-file autofill*=estade@chromium.org	6 # Can not match autofill* due to crbug.com/397984

7 per-file autofill*=isherman@chromium.org	7 per-file autofill.gypi=estade@chromium.org

	8 per-file autofill.gypi=isherman@chromium.org

	9 per-file autofill_strings.grdp=estade@chromium.org

	10 per-file autofill_strings.grpd=isherman@chromium.org
	Ilya Sherman 2014/10/17 22:02:57 nit: "grpd" -> "grdp" nit: "grpd" -> "grdp" Ilya Sherman 2014/10/17 22:02:57 Also, I wonder if we can move this file to live wi Also, I wonder if we can move this file to live within the autofill directory, rather than at the top-level //components directory. (Food for thought, not anything you need to address as part of this CL.) Garrett Casto 2014/10/17 23:17:00 Done. Show quoted text On 2014/10/17 22:02:57, Ilya Sherman wrote: > nit: "grpd" -> "grdp" Done. Garrett Casto 2014/10/17 23:17:00 Acknowledged. Show quoted text On 2014/10/17 22:02:57, Ilya Sherman wrote: > Also, I wonder if we can move this file to live within the autofill directory, > rather than at the top-level //components directory. (Food for thought, not > anything you need to address as part of this CL.) Acknowledged. blundell 2014/10/20 11:31:07 +1, I think it's reasonable to have all the foo-re Show quoted text On 2014/10/17 22:02:57, Ilya Sherman wrote: > Also, I wonder if we can move this file to live within the autofill directory, > rather than at the top-level //components directory. (Food for thought, not > anything you need to address as part of this CL.) +1, I think it's reasonable to have all the foo-related files live under //components/foo, as I mentioned in the chromium-dev@ thread. We should be consistent though, so if someone makes this change, it would be great if they did it for the handful of other grdp files in //components too. Also, this would affect the translation process, so you would have to coordinate with someone who knows about how to make sure that gets adjusted accordingly (e.g., one of the TPMs). tfarina 2014/10/21 15:17:03 There are some complications in doing that. But I There are some complications in doing that. But I don't recall what they are. Tony or Joi might remember. I will look into my mailbox to see if I found the thread about it. I think it is something related to relative paths and how grit deals with that.
8	11

9 per-file bookmarks.gypi=sky@chromium.org	12 per-file bookmarks.gypi=sky@chromium.org

10	13

11 per-file cloud_devices*=gene@chromium.org	14 per-file cloud_devices*=gene@chromium.org

12 per-file cloud_devices*=vitalybuka@chromium.org	15 per-file cloud_devices*=vitalybuka@chromium.org

13	16

14 per-file content_settings*=markusheintz@chromium.org	17 per-file content_settings*=markusheintz@chromium.org

15 per-file content_settings*=bauerb@chromium.org	18 per-file content_settings*=bauerb@chromium.org

16 per-file content_settings*=jochen@chromium.org	19 per-file content_settings*=jochen@chromium.org

17	20

(...skipping 209 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
227	230

228 per-file wifi.gypi=mef@chromium.org	231 per-file wifi.gypi=mef@chromium.org

229	232

230 per-file *.isolate=csharp@chromium.org	233 per-file *.isolate=csharp@chromium.org

231 per-file *.isolate=maruel@chromium.org	234 per-file *.isolate=maruel@chromium.org

232	235

233 # These are for the common case of adding or removing tests. If you're making	236 # These are for the common case of adding or removing tests. If you're making

234 # structural changes, please get a review from one of the overall components	237 # structural changes, please get a review from one of the overall components

235 # OWNERS.	238 # OWNERS.

236 per-file components_tests.gyp=*	239 per-file components_tests.gyp=*

OLD	NEW

« no previous file with comments | « no previous file | components/autofill/OWNERS » ('j') | components/autofill/OWNERS » ('J')