Update Autofill component ownership to avoid bugs in OWNERS file parsing

Update Autofill component ownership to avoid bugs in OWNERS file parsing

BUG=397984
Committed: https://crrev.com/f09f9a4c313ee3fed9ac697632289fde40c742dc
Cr-Commit-Position: refs/heads/master@{#300302}

[Garrett Casto, 2014-10-17 21:30:14]

gcasto@chromium.org changed reviewers:
+ isherman@chromium.org

[Ilya Sherman, 2014-10-17 22:02:57]

LGTM % nits:

https://codereview.chromium.org/658973003/diff/1/components/OWNERS
File components/OWNERS (right):

https://codereview.chromium.org/658973003/diff/1/components/OWNERS#newcode10
components/OWNERS:10: per-file autofill_strings.grpd=isherman@chromium.org
nit: "grpd" -> "grdp"

https://codereview.chromium.org/658973003/diff/1/components/OWNERS#newcode10
components/OWNERS:10: per-file autofill_strings.grpd=isherman@chromium.org
Also, I wonder if we can move this file to live within the autofill directory,
rather than at the top-level //components directory.  (Food for thought, not
anything you need to address as part of this CL.)

https://codereview.chromium.org/658973003/diff/1/components/autofill/OWNERS
File components/autofill/OWNERS (right):

https://codereview.chromium.org/658973003/diff/1/components/autofill/OWNERS#n...
components/autofill/OWNERS:5: # TODO: Change to per-file ownership after
crbug.com/235756 is fixed.
nit: TODO should have an owner, i.e. "TODO(gcasto):"

https://codereview.chromium.org/658973003/diff/1/components/autofill/OWNERS#n...
components/autofill/OWNERS:5: # TODO: Change to per-file ownership after
crbug.com/235756 is fixed.
nit: Please prepend "http://" to the link address.

[Garrett Casto, 2014-10-17 23:16:59]

gcasto@chromium.org changed reviewers:
+ blundell@chromium.org

[Garrett Casto, 2014-10-17 23:17:00]

+blundell for components/OWNERS review.

https://codereview.chromium.org/658973003/diff/1/components/OWNERS
File components/OWNERS (right):

https://codereview.chromium.org/658973003/diff/1/components/OWNERS#newcode10
components/OWNERS:10: per-file autofill_strings.grpd=isherman@chromium.org
On 2014/10/17 22:02:57, Ilya Sherman wrote:
> nit: "grpd" -> "grdp"

Done.

https://codereview.chromium.org/658973003/diff/1/components/OWNERS#newcode10
components/OWNERS:10: per-file autofill_strings.grpd=isherman@chromium.org
On 2014/10/17 22:02:57, Ilya Sherman wrote:
> Also, I wonder if we can move this file to live within the autofill directory,
> rather than at the top-level //components directory.  (Food for thought, not
> anything you need to address as part of this CL.)

Acknowledged.

https://codereview.chromium.org/658973003/diff/1/components/autofill/OWNERS
File components/autofill/OWNERS (right):

https://codereview.chromium.org/658973003/diff/1/components/autofill/OWNERS#n...
components/autofill/OWNERS:5: # TODO: Change to per-file ownership after
crbug.com/235756 is fixed.
On 2014/10/17 22:02:57, Ilya Sherman wrote:
> nit: TODO should have an owner, i.e. "TODO(gcasto):"

Done.

https://codereview.chromium.org/658973003/diff/1/components/autofill/OWNERS#n...
components/autofill/OWNERS:5: # TODO: Change to per-file ownership after
crbug.com/235756 is fixed.
On 2014/10/17 22:02:57, Ilya Sherman wrote:
> nit: Please prepend "http://" to the link address.

Done.

[blundell, 2014-10-20 11:31:07]

lgtm

https://codereview.chromium.org/658973003/diff/1/components/OWNERS
File components/OWNERS (right):

https://codereview.chromium.org/658973003/diff/1/components/OWNERS#newcode10
components/OWNERS:10: per-file autofill_strings.grpd=isherman@chromium.org
On 2014/10/17 22:02:57, Ilya Sherman wrote:
> Also, I wonder if we can move this file to live within the autofill directory,
> rather than at the top-level //components directory.  (Food for thought, not
> anything you need to address as part of this CL.)

+1, I think it's reasonable to have all the foo-related files live under
//components/foo, as I mentioned in the chromium-dev@ thread. We should be
consistent though, so if someone makes this change, it would be great if they
did it for the handful of other grdp files in //components too. Also, this would
affect the translation process, so you would have to coordinate with someone who
knows about how to make sure that gets adjusted accordingly (e.g., one of the
TPMs).

https://codereview.chromium.org/658973003/diff/20001/components/autofill/OWNERS
File components/autofill/OWNERS (right):

https://codereview.chromium.org/658973003/diff/20001/components/autofill/OWNE...
components/autofill/OWNERS:7: gcasto@chromium.org
Is there a need for this? My understanding had been that it the use of a "*" was
only a problem because it masked //components/autofill/OWNERS. There's no
directory under //components/autofill that "*password*" would match.

[Garrett Casto, 2014-10-20 17:56:09]

The CQ bit was checked by gcasto@chromium.org

[Garrett Casto, 2014-10-20 17:56:17]

https://codereview.chromium.org/658973003/diff/20001/components/autofill/OWNERS
File components/autofill/OWNERS (right):

https://codereview.chromium.org/658973003/diff/20001/components/autofill/OWNE...
components/autofill/OWNERS:7: gcasto@chromium.org
On 2014/10/20 11:31:07, blundell wrote:
> Is there a need for this? My understanding had been that it the use of a "*"
was
> only a problem because it masked //components/autofill/OWNERS. There's no
> directory under //components/autofill that "*password*" would match.

Different bug. 235756 is about the fact that per-file directives only affect the
current directory.

[commit-bot: I haz the power, 2014-10-20 17:56:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/658973003/20001

[commit-bot: I haz the power, 2014-10-20 18:23:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-20 18:24:25]

Patchset 2 (id:??) landed as
https://crrev.com/f09f9a4c313ee3fed9ac697632289fde40c742dc
Cr-Commit-Position: refs/heads/master@{#300302}

[tfarina, 2014-10-21 15:17:03]

tfarina@chromium.org changed reviewers:
+ tfarina@chromium.org

[tfarina, 2014-10-21 15:17:03]

https://codereview.chromium.org/658973003/diff/1/components/OWNERS
File components/OWNERS (right):

https://codereview.chromium.org/658973003/diff/1/components/OWNERS#newcode10
components/OWNERS:10: per-file autofill_strings.grpd=isherman@chromium.org
There are some complications in doing that. But I don't recall what they are.
Tony or Joi might remember. I will look into my mailbox to see if I found the
thread about it. I think it is something related to relative paths and how grit
deals with that.