Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 658913002: Tweak out SkTileGrid::insert() loop. (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Tweak out SkTileGrid::insert() loop. BUG=skia: Committed: https://skia.googlesource.com/skia/+/4ba7686eb79a06b7165c007b41cd0cf7bb3ddb2d

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M src/core/SkTileGrid.cpp View 1 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
mtklein
Another Sk4x prequel.
6 years, 2 months ago (2014-10-15 21:19:35 UTC) #2
mtklein
On 2014/10/15 21:19:35, mtklein wrote: > Another Sk4x prequel. Rebased after the other CL landed.
6 years, 2 months ago (2014-10-15 21:22:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658913002/20001
6 years, 2 months ago (2014-10-15 21:23:17 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-15 21:23:19 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 2 months ago (2014-10-16 03:23:22 UTC) #10
reed1
lgtm
6 years, 2 months ago (2014-10-16 14:04:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658913002/20001
6 years, 2 months ago (2014-10-16 14:09:58 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 16:23:25 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 4ba7686eb79a06b7165c007b41cd0cf7bb3ddb2d

Powered by Google App Engine
This is Rietveld 408576698