Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: chrome/browser/metrics/android_metrics_provider.h

Issue 658903002: Starting a refactor to allow adding metrics on upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Style fixes Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/android_metrics_provider.h
diff --git a/chrome/browser/metrics/android_metrics_provider.h b/chrome/browser/metrics/android_metrics_provider.h
index 31a2dbe004a53b8ab8fa8c8685cd2bdc9e3478c4..cfa5b6c15797cea5a5d03bcaa96d5bb1ecc8965f 100644
--- a/chrome/browser/metrics/android_metrics_provider.h
+++ b/chrome/browser/metrics/android_metrics_provider.h
@@ -19,11 +19,14 @@ class AndroidMetricsProvider : public metrics::MetricsProvider {
explicit AndroidMetricsProvider(PrefService* local_state);
virtual ~AndroidMetricsProvider();
+ // metrics::MetricsProvider:
Alexei Svitkine (slow) 2014/10/17 18:30:52 Can you put this in the same section as ProvideSta
Maria 2014/10/17 21:44:50 This file needs to be generally reordered as the c
Alexei Svitkine (slow) 2014/10/20 15:47:00 That sounds fine to me, thanks!
+ void OnCollectFinalMetrics() override;
+
// Called when the Activity that the user interacts with is swapped out.
// TODO(asvitkine): Expose a way for Android code to actually invoke this.
void OnForegroundActivityChanged(ActivityTypeIds::Type type);
- // metrics::MetricsDataProvider:
+ // metrics::MetricsProvider:
virtual void ProvideStabilityMetrics(
metrics::SystemProfileProto* system_profile_proto) override;

Powered by Google App Engine
This is Rietveld 408576698