Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1454)

Unified Diff: chrome/browser/metrics/android_metrics_provider.cc

Issue 658903002: Starting a refactor to allow adding metrics on upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Style fixes Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/android_metrics_provider.cc
diff --git a/chrome/browser/metrics/android_metrics_provider.cc b/chrome/browser/metrics/android_metrics_provider.cc
index ddb41589c715bbea1a3da00abf8d4cc864306d4e..5904d88fef3864bc190f0f26d5b734ab1d0dcb2d 100644
--- a/chrome/browser/metrics/android_metrics_provider.cc
+++ b/chrome/browser/metrics/android_metrics_provider.cc
@@ -9,6 +9,7 @@
#include "base/prefs/pref_service.h"
#include "base/prefs/scoped_user_pref_update.h"
#include "base/values.h"
+#include "chrome/browser/android/feature_utilities.h"
#include "chrome/common/pref_names.h"
namespace {
@@ -37,6 +38,12 @@ AndroidMetricsProvider::AndroidMetricsProvider(PrefService* local_state)
AndroidMetricsProvider::~AndroidMetricsProvider() {
}
+void AndroidMetricsProvider::OnCollectFinalMetrics() {
+ UMA_HISTOGRAM_ENUMERATION(
+ "DocumentMode.Enabled",
Alexei Svitkine (slow) 2014/10/17 18:30:51 Please don't introduce a new top-level prefix. May
Maria 2014/10/17 21:44:50 I am reusing a top level prefix that we use in int
Alexei Svitkine (slow) 2014/10/20 15:47:00 Ah fair enough, OK,
+ chrome::android::GetDocumentModeValue(),
+ chrome::android::HISTOGRAM_MAX);
+}
void AndroidMetricsProvider::ProvideStabilityMetrics(
metrics::SystemProfileProto* system_profile_proto) {

Powered by Google App Engine
This is Rietveld 408576698