Starting a refactor to allow adding metrics on upload.

chrome/browser/metrics/android_metrics_provider.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/android_metrics_provider.h"
 
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/scoped_user_pref_update.h"
 #include "base/values.h"
+#include "chrome/browser/android/feature_utilities.h"
 #include "chrome/common/pref_names.h"
 
 namespace {
 
 // Increments a particular entry in the ListValue.
 void IncrementListValue(base::ListValue* counts, int index) {
   int current_count = 0;
   counts->GetInteger(index, &current_count);
   counts->Set(index, new base::FundamentalValue(current_count + 1));
 }
 
 // Takes an int corresponding to a Type and returns the corresponding flag.
 int GetActivityFlag(int type_id) {
   ActivityTypeIds::Type type = ActivityTypeIds::GetActivityType(type_id);
   DCHECK_LT(type, ActivityTypeIds::ACTIVITY_MAX_VALUE);
   return (1 << type);
 }
 
 }  // namespace
 
 AndroidMetricsProvider::AndroidMetricsProvider(PrefService* local_state)
     : local_state_(local_state) {
   LogStabilityToPrefs();
 }
 
 AndroidMetricsProvider::~AndroidMetricsProvider() {
 }
 
+void AndroidMetricsProvider::OnCollectFinalMetrics() {
+  UMA_HISTOGRAM_ENUMERATION(
+      "DocumentMode.Enabled",

[Alexei Svitkine (slow), 2014/10/17 18:30:51]

Please don't introduce a new top-level prefix. Maybe use the same prefix as the
other histograms logged by this file - Chrome.Android.

Also, since this histogram is recorded by the open source code, can you put its
description in histograms.xml in the Chromium code - in the same CL?

[Maria, 2014/10/17 21:44:50]

I am reusing a top level prefix that we use in internal histograms now. Is that
ok? Also added the histograms.xml entry.

[Alexei Svitkine (slow), 2014/10/20 15:47:00]

Ah fair enough, OK,

+      chrome::android::GetDocumentModeValue(),
+      chrome::android::HISTOGRAM_MAX);
+}
 
 void AndroidMetricsProvider::ProvideStabilityMetrics(
     metrics::SystemProfileProto* system_profile_proto) {
   ConvertStabilityPrefsToHistograms();
 }
 
 void AndroidMetricsProvider::LogStabilityToPrefs() {
   // Track which Activities were launched by the user.
   // A 'launch' is defined as starting the Activity at least once during a
   // UMA session.  Multiple launches are counted only once since it is possible
@@ skipping 88 matching lines @@
 }
 
 // static
 void AndroidMetricsProvider::RegisterPrefs(PrefRegistrySimple* registry) {
   registry->RegisterIntegerPref(prefs::kStabilityForegroundActivityType,
                                 ActivityTypeIds::ACTIVITY_NONE);
   registry->RegisterIntegerPref(prefs::kStabilityLaunchedActivityFlags, 0);
   registry->RegisterListPref(prefs::kStabilityLaunchedActivityCounts);
   registry->RegisterListPref(prefs::kStabilityCrashedActivityCounts);
 }