Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 658813003: [x64] simply tweak materialization of float/double constants (Closed)

Created:
6 years, 2 months ago by Weiliang
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[x64] simply tweak materialization of float/double constants port 24485 Fixed a bug of "psllq" instruction in x64 R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24673

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -8 lines) Patch
M src/compiler/x64/code-generator-x64.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M src/x64/assembler-x64.h View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 2 3 chunks +44 lines, -0 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/disasm-x64.cc View 1 2 1 chunk +7 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 1 chunk +51 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Weiliang
PTAL
6 years, 2 months ago (2014-10-16 00:52:38 UTC) #2
Benedikt Meurer
How about porting the MacroAssembler::Move(XMMRegister, intX_t) functions to X64 instead?
6 years, 2 months ago (2014-10-16 05:35:21 UTC) #3
Weiliang
On 2014/10/16 05:35:21, Benedikt Meurer wrote: > How about porting the MacroAssembler::Move(XMMRegister, intX_t) functions to ...
6 years, 2 months ago (2014-10-16 08:01:09 UTC) #4
Benedikt Meurer
Yeah, long-term plan is to use constant pool. Still, isn't it faster to materialize inside ...
6 years, 2 months ago (2014-10-16 08:20:28 UTC) #5
Weiliang
On 2014/10/16 08:20:28, Benedikt Meurer wrote: > Yeah, long-term plan is to use constant pool. ...
6 years, 2 months ago (2014-10-17 04:02:08 UTC) #6
Benedikt Meurer
LGTM, will land, thanks.
6 years, 2 months ago (2014-10-17 04:18:22 UTC) #7
Benedikt Meurer
6 years, 2 months ago (2014-10-17 04:18:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 24673 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698